Comments (2)
Thanks @pawelproject for raising this. IMHO your second proposal sounds good due to the nature of the event. It should be considered as an accept only on the calendar and therefor it is generally correct to fire the event, even with this invalid date.
WDYT @LukasTy ?
from mui-x.
@pawelproject thank you for a great observation. 🙏
Comparing the information in the lifecycle docs and the actual behavior in this particular case suggests that we need to fix this behavior or update the documentation. 🙈
IMHO, both suggested approaches seem valid, however, it's probably a bit less error-prone to go with the second option of also including a context in onAccept
parameters.
In the meantime, I'd suggest you also listen to the onError
callback and fire a backend request only when error === null
.
What do you think? Would it be a valid compromise? 🤔
from mui-x.
Related Issues (20)
- [data grid] Rename gridClasses to dataGridClasses HOT 3
- [pickers] popup jumps to the top left after selection if custom TextField slot is given HOT 3
- [support] What is the latest version I should be able to access with my license? HOT 2
- [question] [DataGrid] updateRows method changing order of Rows HOT 2
- [data grid] Date selector in date column filter inconsistent with date picker component HOT 4
- [charts] Support `themeAugmentation`
- [data grid] Remove the unused legacy editing API event `rowEditCommit` HOT 1
- [pickers] Allow to refuse ranges that contains at least one disabled date HOT 5
- Move focus up after an edit when shift enter is pressed
- [pickers] Enhancing User Experience: Introducing Month and Year Selection in Date-Pickers HOT 5
- [TreeView][ESM] package exports are incorrect HOT 4
- Make Loading overlay states change based on data HOT 6
- [pickers] Ensuring Comprehensive Validation for Date and DateTime Range Fields HOT 2
- [charts] Axis min/max does not allow dynamic rescaling of the other Axis when that axis has no min/max set HOT 6
- [pickers] Ineffective Date and Time Validation Despite minTime, maxTime, and disableIgnoringDatePartForTimeValidation Settings HOT 2
- [data grid] Dynamic Aggregation Position HOT 7
- [How to get column widths exact on resize within detail panel based on Data Grid columns] HOT 2
- [data grid] Is it possible to have tree data row children open and under that details panel? HOT 9
- [data grid] Same column in different column groups HOT 8
- ThemeProvider not provide Translation keys. HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mui-x.