Code Monkey home page Code Monkey logo

Comments (2)

michelengelen avatar michelengelen commented on September 17, 2024

Thanks @pawelproject for raising this. IMHO your second proposal sounds good due to the nature of the event. It should be considered as an accept only on the calendar and therefor it is generally correct to fire the event, even with this invalid date.

WDYT @LukasTy ?

from mui-x.

LukasTy avatar LukasTy commented on September 17, 2024

@pawelproject thank you for a great observation. 🙏
Comparing the information in the lifecycle docs and the actual behavior in this particular case suggests that we need to fix this behavior or update the documentation. 🙈
IMHO, both suggested approaches seem valid, however, it's probably a bit less error-prone to go with the second option of also including a context in onAccept parameters.

In the meantime, I'd suggest you also listen to the onError callback and fire a backend request only when error === null.
What do you think? Would it be a valid compromise? 🤔

from mui-x.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.