Comments (10)
Our ux decided to proceed with different ui but this component is awesome and a true RTL support would benefit to others for sure(i have not trying override styles with slots)
from mui-x.
Hello @Eliav2. Thank you for creating this issue! 🙏
Could you please confirm if we understand the expected behavior correctly?
Would you expect the hours
and minutes
sections to be swapped in this case to reflect how the Digital Clock
renders time?
from mui-x.
@Eliav2 would you be able to clarify the expected tabulation order for the MultiSectionDigitalClock
in RTL mode?
Does the focus order of following the views order make sense?
In the default case, it would be: hours, minutes, and meridiem.
cc @MBilalShafi if you can confirm this. 🙏
from mui-x.
Yes, exactly. I would even suggest considering adding an option to pass props to any inner element to allow full customization including overriding styles
(if this is already possible sorry about it)
from mui-x.
Thank you for clarifying. 👍
I would even suggest considering adding an option to pass props to any inner element to allow full customization including overriding styles
There is the digitalClockSectionItem
slot that you can target using slotProps
. Does it allow you to achieve what you need? 🤔
from mui-x.
@Eliav2, I'm curious about your UX team's decision. What are you using now instead of the MUI X time picker?
from mui-x.
Because we focus on relative time(eg hours,minutes ,seconds from now) we just used 3 mui Select components to represent hours,minutes, seconds. @joserodolfofreitas
from mui-x.
Hours should be on the left. Minutes right to them. Seconds right to them. Time are internetional.
The resolution is as simple as adding sx={direction:ltr} on the right div. Because direction ordering should never change on nunbers. They are always the same.
from mui-x.
Hey @Eliav2, thanks for the suggestion!
The way I see it, to implement your idea we'd need to create a new div to wrap the number sections separately from the meridiem. Although it might be a simple move, this would affect some critical parts of our components and might cause breaking changes in the DOM structure that could affect someone doing some CSS magic.
We can surely consider this for the next major version, but, for now, the best solution I see is to refactor how we order the sections considering the different directions.
Suggestions, comments and reviews are very welcome ! 😄
from mui-x.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.
@Eliav2: How did we do? Your experience with our support team matters to us. If you have a moment, please share your thoughts in this short Support Satisfaction survey.
from mui-x.
Related Issues (20)
- [data grid] Issue with Korean Input in DataGrid Causing Duplicated Characters HOT 1
- [data grid] Using grid filter with `{ value: -1, label: 'All' }` pagesize option shows all rows minus 1 HOT 1
- [tree view] Add `getItemChildren` HOT 1
- [question][BarChart] How can I fix the BarChart tooltip on top of the bar? HOT 2
- Filtering and Sorting Not Working Correctly for Text Columns in DataGrid Using renderCell HOT 3
- [pickers] Handle `TextField` slots with `@mui/material@6`
- [data grid] Selection Column has no aria-label for screen reader a11y HOT 5
- [data grid] In column filter dropdowns HOT 2
- [data grid] Overlays aren't sticky in RTL mode HOT 1
- [x-license] MUI Missing license key HOT 1
- [charts] line charts not rendering on page load, only on mouse over HOT 3
- DatePicker format issue when format='DD/MMM/YYYY' UI shows "DD/MMMM/YYYY" HOT 2
- [tree view] Cursor navigation interferes with browser shortcut keys HOT 1
- [data grid] State change in component when `groupingColDef` and `pinnedColumns` leads to mis-render in Group column HOT 5
- [data grid] Warning: A props object containing a "key" prop is being spread into JSX HOT 2
- [data grid] Update `indeterminateCheckboxAction` default value
- [data grid] How to setup clickable value (like links) in input field HOT 1
- [charts] Generate chart images on the backend / from an HTTP API
- [charts] Missing `themeAugmentation` in pro plan HOT 1
- [charts-pro] Dependency local workspace reference causes runtime errors on ``createAxisFilterMapper`` HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mui-x.