Code Monkey home page Code Monkey logo

Comments (10)

Eliav2 avatar Eliav2 commented on September 7, 2024 2

Our ux decided to proceed with different ui but this component is awesome and a true RTL support would benefit to others for sure(i have not trying override styles with slots)

from mui-x.

LukasTy avatar LukasTy commented on September 7, 2024 1

Hello @Eliav2. Thank you for creating this issue! 🙏
Could you please confirm if we understand the expected behavior correctly?
Screenshot 2023-12-28 at 10 05 36
Would you expect the hours and minutes sections to be swapped in this case to reflect how the Digital Clock renders time?

from mui-x.

LukasTy avatar LukasTy commented on September 7, 2024 1

@Eliav2 would you be able to clarify the expected tabulation order for the MultiSectionDigitalClock in RTL mode?
Does the focus order of following the views order make sense?
In the default case, it would be: hours, minutes, and meridiem.

cc @MBilalShafi if you can confirm this. 🙏

from mui-x.

Eliav2 avatar Eliav2 commented on September 7, 2024

Yes, exactly. I would even suggest considering adding an option to pass props to any inner element to allow full customization including overriding styles
(if this is already possible sorry about it)

from mui-x.

LukasTy avatar LukasTy commented on September 7, 2024

Thank you for clarifying. 👍

I would even suggest considering adding an option to pass props to any inner element to allow full customization including overriding styles

There is the digitalClockSectionItem slot that you can target using slotProps. Does it allow you to achieve what you need? 🤔

from mui-x.

joserodolfofreitas avatar joserodolfofreitas commented on September 7, 2024

@Eliav2, I'm curious about your UX team's decision. What are you using now instead of the MUI X time picker?

from mui-x.

Eliav2 avatar Eliav2 commented on September 7, 2024

Because we focus on relative time(eg hours,minutes ,seconds from now) we just used 3 mui Select components to represent hours,minutes, seconds. @joserodolfofreitas

from mui-x.

Eliav2 avatar Eliav2 commented on September 7, 2024

Hours should be on the left. Minutes right to them. Seconds right to them. Time are internetional.

The resolution is as simple as adding sx={direction:ltr} on the right div. Because direction ordering should never change on nunbers. They are always the same.

from mui-x.

arthurbalduini avatar arthurbalduini commented on September 7, 2024

Hey @Eliav2, thanks for the suggestion!
The way I see it, to implement your idea we'd need to create a new div to wrap the number sections separately from the meridiem. Although it might be a simple move, this would affect some critical parts of our components and might cause breaking changes in the DOM structure that could affect someone doing some CSS magic.
We can surely consider this for the next major version, but, for now, the best solution I see is to refactor how we order the sections considering the different directions.
Suggestions, comments and reviews are very welcome ! 😄

from mui-x.

github-actions avatar github-actions commented on September 7, 2024

⚠️ This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

@Eliav2: How did we do? Your experience with our support team matters to us. If you have a moment, please share your thoughts in this short Support Satisfaction survey.

from mui-x.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.