[DataGrid] Can a custom filtering implementation make use of MUI's filter state? about mui-x HOT 8 CLOSED

Hi there @cherniavskii,

My bad, I kept testing around and forgot to revert the demo back to the bug. Corrected now:

Notice how after firing the columnsChange event (STEP 2) the custom filterModel.items get cleared (STEP 3).

Anecdotically, in my CustomDataGrid I've even gotten to fire columnsChange just by changing the filterModel, without even changing the state of the rows.

Solution / patch

I had to keep on going with my development, so what I ended up doing is to:

• take the filters that use a field not present,
• dinamically add columns with those fields,
• hide those columns through the columnVisibilityModel, and
• disable the column selection functionality from the user.

Expected behavior

I would love to be able to have filters with custom fields (and not have to use a patch), but I feel you guys are on a better position to define what the library should support or not so I'll leave that up to you.

In any case, the options are:

• Not allow custom filters (i.e. filterModel with fields not present in the columns definition). In that case, what I'm reporting is not a bug, but a feature.
• Allow custom filters. In this case, what I'm reporting is indeed a bug or needs a change.

from mui-x.

@cherniavskii gentle ping on this.

from mui-x.

Thanks @apedretti

The reason we only support filtering for the fields that are included in the columns prop is that we need to know the type of the field and filter operators available for the field:

Suppose the field is missing in the column definitions. In that case, it's not safe to assume the type, and keeping these filters in the filter model could lead to various inconsistencies in the Data Grid UI - this is why the Data Grid cleans the filter model and removes non-existent fields.

Your current solution to the problem is straightforward and makes sense to me 👍🏻

from mui-x.

Hey @apedretti
Could you clarify the expected behavior? This is what I see in the console:

from mui-x.

Also, could you clarify what is the expected behavior when the filterModel includes items referring to the non-existent columns?

from mui-x.

Here's a demo if anyone else has a similar use case: https://codesandbox.io/p/sandbox/summer-frost-lwsqyt?file=%2Fsrc%2FDemo.tsx%3A94%2C53

But I have to admit that when filtering by hidden fields, it's not clear why specific rows pass the filtering while others don't.
I think this is not great in terms of UX.

from mui-x.

I think we can close the issue as there's no action for us to take on the Data Grid side.
Thanks for your feedback!

from mui-x.

Thanks a lot @cherniavskii

from mui-x.