Comments (10)
I created a typescript playground with all the problems I could find, including this one:
- If only the
Value
type argument is provided, inference onVariant
doesn't work due to microsoft/TypeScript#10571 - If the
Variant
type arguments are provided with value"standard"
or"filled"
, but thevariant
prop is not provided, then the"outlined"
variant will be rendered. TS should catch this. - When trying to wrap the Select, variant is incorrectly required and inference stops working (this issue)
from material-ui.
Hey @maapteh, thanks for the report.
Also reported here: #39137 (comment)
I'll look into it this week
from material-ui.
Thank you, i looked but search didnt find anything. I will see if making them optional again will fix my issue.
FYI, this is breaking type change for people using SelectProps
directly because the variant prop is required now when it wasn't
before. I guess BaseSelectProps is a suitable replacement
for most use cases?
This was helpful but not fixing the root cause:)
from material-ui.
I created a fix in the PR attached to this issue report!
from material-ui.
Please look at it @DiegoAndai when you find the time :)
from material-ui.
Hey @maapteh, may I ask you to provide a minimal reproduction? This would help a lot in debugging the issue. A live example would be perfect. This StackBlitz sandbox template may be a good starting point.
from material-ui.
I solved it in #41359 right?
from material-ui.
I'm not sure, I left a comment there
from material-ui.
Ah now i see, but its a union type so i dont see how that would work...
I created the sample at https://stackblitz.com/edit/stackblitz-starters-gfn7kp?file=src%2FApp.tsx
from material-ui.
I'll add the ready to take
label to see if we get any contributors with ideas. This is the isolated repro: typescript playground. If you have an idea on how to support wrapping the Select component and avoid the errors in the playground, let's discuss here.
from material-ui.
Related Issues (20)
- [material-ui] Next.js 14 with NX monorepo build fails on PonyfillGlobal HOT 3
- [docs-infra] Dark mode not persisting after switching from light mode HOT 8
- Module not found: Error: Can't resolve '@mui/base/className' in '/app/node_modules/********/ui-toolkit/node_modules/@mui/material/utils' HOT 1
- [joy-ui][Button] The user can see the text by highlighting when loading is true
- @mui/material incompatible with versions of @types/react > 18.2.60
- [system][docs] Missing content regarding possible Box's styling approaches HOT 1
- Autocomplete popupIcon icon is turning down HOT 3
- [website] Inconsistent card display at 100% zoom level HOT 1
- [system] useColorScheme should return null during hydration
- [material-ui][Menu] Submenu closes improperly HOT 5
- [website] Site responsiveness and adaptability when zooming HOT 4
- [material-ui][Menu] Issues building a context menu HOT 4
- [material-ui] Standardize event handler callbacks
- [material-ui][Autocomplete] click on helperText inside of Autocomplete component triggers input focus/option selection HOT 7
- [material-ui][Switch] Issues with styling before refreshing the page HOT 5
- Styleprovider doesn't seem to work on dynamically rendered components inside shadow dom HOT 5
- [material-ui][Switch] Unsupported color after upgrade @mui/material to 5.15.13 HOT 4
- CSP issue in React Project
- [material-ui][Typography] Migrating from v4 to v5 issue HOT 2
- [joy-ui] The latest betas aren't available on `latest` HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from material-ui.