[docs-infra] Product switcher popup not closing about material-ui HOT 5 CLOSED

Hey @oliviertassinari I can work on resolving this bug. It would be great if you can assign this to me.

from material-ui.

This should be a simple bug to fix but one that will be increasingly more annoying as we improve the use of "layouts" in our docs to improve performance.

@divyammadhok Go ahead, thanks

from material-ui.

Hey @oliviertassinari I added a PR for this issue - 41128
Now there were 2 approaches - either track for page changes and close the popper or pass the close callback through props and call it whenever the links are clicked but the 2nd approach felt a bit more manual to handle. Every time a new link / component is added we would need to handle for this handleClose callback so I instead went ahead with the 1st approach by tracking page changes.

from material-ui.

Same bug, the user feedback is broken, it should close when going to the same area:

https://mui.com/material-ui/getting-started/

Off-topic wonder if we shouldn't open in a new tab as the Google app switcher works:

from material-ui.

@oliviertassinari
Ah Gotcha, so for the same tab as the opened route we need it to close, then I believe the best path forward would be to pass an event to close it whenever it is clicked and treat every item as a close button.

Yeah, but for Google app switcher I believe the motivation is that it's possible a user is editing on the current tab but for MUI docs it's more of a readonly documentation, so not sure, if opening in new tab good for UX. Also you can check this accessibility guideline for redirection in new tab https://www.w3.org/TR/WCAG20-TECHS/G201.html Ideally from a better accessibility perspective it's advised to open in same tab as opening in new tab takes away from the ability to use back to continue where they were previously.

Edit: Kindly check the PR once more, have updated the logic.

from material-ui.