[material-ui][Pagination] Out of range error about material-ui HOT 5 OPEN

Adding this piece of code in the TablePagination component fixes this issue:

 React.useEffect(() => {
    const newLastPage = Math.max(0, Math.ceil(count / rowsPerPage) - 1);
    if (page > newLastPage) {
      onPageChange(null, newLastPage);
    }
  }, [count, page, rowsPerPage, onPageChange]);

However should this fix be implemented in the component itself? If so, I can open a pull request for this fix - however in my honest opinion it would pollute the component itself. What do you guys think?

from material-ui.

Thanks for your reply, I've tried this in the sandbox : https://codesandbox.io/p/sandbox/zealous-perlman-forked-9kskcl
But problem is the same, we come back to first page, but Mui error appears again

from material-ui.

Yep, this happens because of line 374 in the TablePagination.js component.

I would propose to add the useEffect fix in the component itself (in the core component I mean) and remove this warning since that use case will be handled with the useEffect.

from material-ui.

You mean in the node_module folder ??? There isn't another solution ?

from material-ui.

You mean in the node_module folder ??? There isn't another solution ?

No no, I mean I meant to add this code in the core package so it gets fixed for you, but that was more of a question to the maintainers haha, sorry for the confusion.

from material-ui.