Code Monkey home page Code Monkey logo

Comments (12)

grechut avatar grechut commented on March 29, 2024

👍

from material-ui.

felixakiragreen avatar felixakiragreen commented on March 29, 2024

👍

from material-ui.

mcwhittemore avatar mcwhittemore commented on March 29, 2024

+1

from material-ui.

hai-cea avatar hai-cea commented on March 29, 2024

Yes, I think we'd definitely like to go in this direction. We'll work this into the next release or 2.

from material-ui.

Farhan77 avatar Farhan77 commented on March 29, 2024

H

from material-ui.

kylefinley avatar kylefinley commented on March 29, 2024

Maybe you could keep both. For menus and navigation, where the structure is well known, I think it makes sense to make it more of a configuration. If I want to quickly implement a menu I don't want to import/remember all of the sub menu components.

Wouldn't a simple if statement allow for overrides, though. Something like:

if (this.props.children) {
 return this.props.children;
} else {
  // Build it using the config
}

from material-ui.

mcwhittemore avatar mcwhittemore commented on March 29, 2024

@kylefinley are you looking to have the config so you don't have to recreate the same jsx over and over again? If so, how are you doing this with the config? Can you just replace that with JSX dom structures?

from material-ui.

kylefinley avatar kylefinley commented on March 29, 2024

@mcwhittemore,

Yes, I see your point.

I'm new to React, so perhaps my suggestion is not idiomatic. But the thing I like about the current implementation, and React for that matter, is that it feels more like JavaScript than HTML. Instead of using JSX, or even nested React functions; Material-UI simply uses JavaScript data structure (Objects and Arrays) to define the structure, E.g. Menus

At the end of the day it's just personal preference. I just though that the use of Objects and Arrays to define the structure was novel. Obviously it only works if you are able to optimize for the 95% usecase and allow overriding with JSX dom for the remaining 5%.

from material-ui.

mcwhittemore avatar mcwhittemore commented on March 29, 2024

@kylefinley I feel you. One of the things that using react also does though is let your templates and your js merge so that your typical html/css devs work on end product and not just mocks.

from material-ui.

arianvp avatar arianvp commented on March 29, 2024

Has there be any updates in this regard? I'm very interested in this.

from material-ui.

eliquious avatar eliquious commented on March 29, 2024

+1

from material-ui.

yongxu avatar yongxu commented on March 29, 2024

#1319
I made this that does exactly what you are expecting!

from material-ui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.