Comments (15)
So this looks like a bug in PBR based on the stack trace, but I haven't confirmed that. Just curious which versions of pbr and pip are on your system?
Stestr isn't really doing anything special in its pbr usage. So I don't have any hints off the top of my head on what is causing this.
from stestr.
Thanks @mtreinish,
pbr 3.1.1
pip 10.0.0 from /usr/local/lib/python2.7/site-packages/pip (python 2.7)
from stestr.
Ok cool, there is known issue with windows and pbr 4.0.0. So it's good to rule that out here. Pip 10 was just released, do you have the same issue with pip <10? I don't have a Mac environment to test things on, but I'm thinking pip 10 might have changed something and that's causing the issue.
from stestr.
FYI, I just tested to install stestr with pip on my mac(Mac mini). And there's no issue for the installation.
My environment:
System Version: macOS 10.13.3 (17D47)
Kernel Version: Darwin 17.4.0
pip 10.0.0
pbr 4.0.2
stestr 2.0.0
from stestr.
@masayukig yeah I'm thinking the issue here is a mix of localization settings having git use unicode characters and pbr < 4.0.2. I just took a look at recent pbr commits and came across: openstack/pbr@7767c44 which seems to support this idea. So we need to see if the issue persists on 4.0.2.
If using pbr 4.0.2 fixes this that's good and we know how to workaround this for now. But we'll have a potential issue when we try to release stestr next. We had to cap the pbr version in stestr because of a bug in pbr: https://bugs.launchpad.net/pbr/+bug/1761134 on windows. So we'll have to sort that out if we need pbr 4.0.2 to fix this.
from stestr.
@mtreinish ok, I see and agree with that.
FYI, I've also tested with some combinations like pbr3.1.1 and environment variables(LC_ALL, LANG, etc). But I couldn't reproduce the issue yet, though. But I think there are still some differences from @TommyLike 's environment. So, this is not so surprising.
from stestr.
Thanks @mtreinish and @masayukig, Now I would like to try another mac to see if this is a individual issue:)
from stestr.
I'm curious what the output of git --version looks like on TommyLike's system. On mine it's this:
[bnemec@RedHat ~]$ git --version
git version 2.13.6
I suppose it's possible that if "version" is localized it could end up with unicode data in it.
from stestr.
thanks @cybertron, looks like normal.
╰─$ git --version
git version 2.13.0
from stestr.
The bug is finally located, I have to append these two lines in my zshrc file.
export LC_ALL=en_US.UTF-8
export LANG=en_US.UTF-8
from stestr.
Thanks everyone:)
from stestr.
@TommyLike I think that's just a workaround. So, I think the issue isn't resolved yet. Especially for multibytes language environment users like us :)
@mtreinish I think we shouldn't close this issue yet. What do you think?
from stestr.
Yeah, I consider setting a different localization setting as just a workaround not actually a fix for the bug. We really should be able to make this work in an environment with any localization settings. That being said I think this is still probably a pbr bug of some sort. I'm fine with keeping this open until we get it truly sorted.
from stestr.
Weird, that version output doesn't appear to have any unicode characters in it. I wonder if there's an error/warning message in the actual call that has unicode. I've run into something like that before.
Anyway, it seems like we should probably make pbr handle unicode from this call. It would be helpful if we can get a reproducer so we can verify that any fixes actually work.
from stestr.
I'm closing this since we haven't been able to reproduce it in the year since and I haven't seen any more details on this.
from stestr.
Related Issues (20)
- Deprecate subunit2sql repository? HOT 2
- Finish deprecation and removal of blacklist, black_regex, and whitelist
- Finish deprecation of sql repository type and --repository-type argument
- stestr run fails with stestr: 'run' is not a stestr command. See 'stestr --help'. with Python 3.10 HOT 3
- stestr run specific test but it is skipped by other test's skiptest requirement
- Support for clean termination on receiving SIGNIT HOT 2
- ResourceWarning messages being printed HOT 1
- stestr doesn't handle unittest.subTests well in its output log HOT 1
- Test are run out of order when using `--load-list`
- Commands not found on Debian Buster ('init' is not a stestr command.) HOT 4
- Ignore erroneous files that don't contain the required test
- pyproject.toml support
- New release? HOT 3
- Stestr does not work with python-subunit 1.4.3 and testtools 2.6.0 HOT 1
- Stestr does not work with python-subunit 1.4.3 HOT 1
- stestr==4.0.1 does not have a run command HOT 3
- Cannot use pyproject.toml configs on the first run
- Add Pytest based test executor
- Testcase run twice when import a class with testcase in python file.
- FAIL: stestr.tests.test_return_codes.TestReturnCodesToxIni.test_no_repo_dir on `python 3.12.2` HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from stestr.