Code Monkey home page Code Monkey logo

Comments (15)

mtreinish avatar mtreinish commented on June 26, 2024

So this looks like a bug in PBR based on the stack trace, but I haven't confirmed that. Just curious which versions of pbr and pip are on your system?

Stestr isn't really doing anything special in its pbr usage. So I don't have any hints off the top of my head on what is causing this.

from stestr.

TommyLike avatar TommyLike commented on June 26, 2024

Thanks @mtreinish
pbr 3.1.1
pip 10.0.0 from /usr/local/lib/python2.7/site-packages/pip (python 2.7)

from stestr.

mtreinish avatar mtreinish commented on June 26, 2024

Ok cool, there is known issue with windows and pbr 4.0.0. So it's good to rule that out here. Pip 10 was just released, do you have the same issue with pip <10? I don't have a Mac environment to test things on, but I'm thinking pip 10 might have changed something and that's causing the issue.

from stestr.

masayukig avatar masayukig commented on June 26, 2024

FYI, I just tested to install stestr with pip on my mac(Mac mini). And there's no issue for the installation.

My environment:

System Version: macOS 10.13.3 (17D47)
Kernel Version: Darwin 17.4.0
pip 10.0.0
pbr 4.0.2
stestr 2.0.0

from stestr.

mtreinish avatar mtreinish commented on June 26, 2024

@masayukig yeah I'm thinking the issue here is a mix of localization settings having git use unicode characters and pbr < 4.0.2. I just took a look at recent pbr commits and came across: openstack/pbr@7767c44 which seems to support this idea. So we need to see if the issue persists on 4.0.2.

If using pbr 4.0.2 fixes this that's good and we know how to workaround this for now. But we'll have a potential issue when we try to release stestr next. We had to cap the pbr version in stestr because of a bug in pbr: https://bugs.launchpad.net/pbr/+bug/1761134 on windows. So we'll have to sort that out if we need pbr 4.0.2 to fix this.

from stestr.

masayukig avatar masayukig commented on June 26, 2024

@mtreinish ok, I see and agree with that.

FYI, I've also tested with some combinations like pbr3.1.1 and environment variables(LC_ALL, LANG, etc). But I couldn't reproduce the issue yet, though. But I think there are still some differences from @TommyLike 's environment. So, this is not so surprising.

from stestr.

TommyLike avatar TommyLike commented on June 26, 2024

Thanks @mtreinish and @masayukig, Now I would like to try another mac to see if this is a individual issue:)

from stestr.

cybertron avatar cybertron commented on June 26, 2024

I'm curious what the output of git --version looks like on TommyLike's system. On mine it's this:

[bnemec@RedHat ~]$ git --version
git version 2.13.6

I suppose it's possible that if "version" is localized it could end up with unicode data in it.

from stestr.

TommyLike avatar TommyLike commented on June 26, 2024

thanks @cybertron, looks like normal.

╰─$ git --version
git version 2.13.0

from stestr.

TommyLike avatar TommyLike commented on June 26, 2024

The bug is finally located, I have to append these two lines in my zshrc file.

export LC_ALL=en_US.UTF-8
export LANG=en_US.UTF-8

from stestr.

TommyLike avatar TommyLike commented on June 26, 2024

Thanks everyone:)

from stestr.

masayukig avatar masayukig commented on June 26, 2024

@TommyLike I think that's just a workaround. So, I think the issue isn't resolved yet. Especially for multibytes language environment users like us :)

@mtreinish I think we shouldn't close this issue yet. What do you think?

from stestr.

mtreinish avatar mtreinish commented on June 26, 2024

Yeah, I consider setting a different localization setting as just a workaround not actually a fix for the bug. We really should be able to make this work in an environment with any localization settings. That being said I think this is still probably a pbr bug of some sort. I'm fine with keeping this open until we get it truly sorted.

from stestr.

cybertron avatar cybertron commented on June 26, 2024

Weird, that version output doesn't appear to have any unicode characters in it. I wonder if there's an error/warning message in the actual call that has unicode. I've run into something like that before.

Anyway, it seems like we should probably make pbr handle unicode from this call. It would be helpful if we can get a reproducer so we can verify that any fixes actually work.

from stestr.

mtreinish avatar mtreinish commented on June 26, 2024

I'm closing this since we haven't been able to reproduce it in the year since and I haven't seen any more details on this.

from stestr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.