Comments (2)
dbogdanov
commented on September 25, 2024
1
Indeed, this normalization behavior is redundant nor it is following the original paper that the algorithm cites (Tolonen & Karjalainen, 2000), and I cannot find a reason this normalization was added in the first place. A pull request with a fix is welcome.
PercivalBpmEstimator is the only Essentia algorithm using generalized auto-correlation, so we should double check that its behavior is not affected.
Also test_autocorrelation.py is missing a test for the generalized case.
from essentia.
andresbrocco
commented on September 25, 2024
@dbogdanov I don't think this issue should be labeled "algorithms QA". Instead, it should be on "bug".
from essentia.
Related Issues (20)
- Import and runtime error on M1 Mac. Is Essentia Python wheels compatible with older version like Big Sur? HOT 10
- cannot import name 'TensorflowPredictMusiCNN' from 'essentia.standard' HOT 4
- Adding CMake and VS2019/2022 support HOT 32
- Update Vamp plugin to the latest Vamp SDK
- MSVC Vamp plugin builds for Windows
- speech vs music algorithms HOT 3
- Unexpected performance in melody tracking
- PitchMelodia requires 8192 samples
- Build fails with "error: ‘av_register_all’ was not declared in this scope" HOT 3
- Pip install fail on Linux HOT 3
- Get rid of "MusicExtractorSVM: no classifier models were configured by default" HOT 1
- Change in frameCutter ? Error when checking types. Expected: Real, received: std::vector<Real>
- Description Issue of MelBands
- Warning about python wheel record file HOT 1
- Affero GPLv3 License link broken in documentation
- Benchmarking PitchYin for real-time
- Issues with FFmpeg and LibAV building essentia in macOS 10.15.7 HOT 2
- TF_FORCE_GPU_ALLOW_GROWTH seems to have no effect
- Declaring parameters section outdated in the documentation
- Build with ffmpeg error when cross compile for iOS
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from essentia.