Comments (3)
Yeah, looks like we need to do something along these lines:
diff --git a/src/git-wrapper/git-wrapper.c b/src/git-wrapper/git-wrapper.c
index 0618442..269145a 100644
--- a/src/git-wrapper/git-wrapper.c
+++ b/src/git-wrapper/git-wrapper.c
@@ -18,7 +18,8 @@ int __stdcall wmain(void)
int main(void)
#endif
{
- int r = 1, wait = 1;
+ DWORD exit_code = 0;
+ int wait = 1;
WCHAR exepath[MAX_PATH], exe[MAX_PATH];
LPWSTR cmd = NULL, path2 = NULL, exep = exe;
UINT codepage = 0;
@@ -148,13 +149,15 @@ int main(void)
NULL, /* environment: use parent */
NULL, /* starting directory: use parent */
&si, &pi);
- if (wait)
- WaitForSingleObject(pi.hProcess, INFINITE);
+ if (wait) {
+ WaitForSingleObject(pi.hProcess, INFINITE);
+ GetExitCodeProcess(pi.hProcess, &exit_code);
+ }
}
free(cmd);
/* reset the console codepage */
SetConsoleCP(codepage);
- ExitProcess(r);
+ ExitProcess(exit_code);
}
from git.
Agreed - I've a patch basically doing just that.
Duplicate of msysgit/msysgit#43
from git.
I doubt the scripts started 'crashing' - failing perhaps. An updated git.exe wrapper and the updated source have been pushed to the devel branch of msysgit/msysgit so please try them out so we can do an updated installer as soon as possible.
from git.
Related Issues (20)
- Redirect to Git for Windows 2.x HOT 10
- Why I am not able to use curl commands ? HOT 1
- "Entrust Root Certification Authority - G2" is not trusted HOT 5
- .git subdirectory is created in the wrong place on checkout when using relative directory HOT 16
- umeng123
- Windows installer not cryptographically signed. HOT 3
- Using mingw-perl HOT 5
- git rev-list crashes when --show-notes and --grep are specified HOT 2
- Git SVN crash HOT 3
- Git daemon and TortoiseGit HOT 2
- fox
- Git Blame - file.dot is not a Word Document HOT 3
- Missing patch tool for release candidate of Git for Windows. HOT 1
- Custom mergetool cmd support in git GUI HOT 1
- Git.exe is stuck if I run a wrong command. HOT 1
- Not able to clone gerrit repo over https via gitbash(windows client) HOT 5
- please add a release to announce the move of release downloads to the git-for-windows repo HOT 7
- <invalid>
- Filename too long when cloning a repo HOT 3
- Cannot Create Shortcut, Cannot Find App, Cannot Open App HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from git.