Code Monkey home page Code Monkey logo

Comments (6)

nzakas avatar nzakas commented on September 27, 2024 3

FWIW, the same problem exists when using a REST API. I'm using Mocha and my test won't exit if I POST using FormData.

Note: A FormData object with no fields does not cause this problem, but as soon as you add a single field, the process hangs.

Here is a simple repo using Mocha and msw 2.2.3:
https://stackblitz.com/edit/stackblitz-starters-rprzyx?file=index.js

I tested all the way back to v2.0.0 and this same behavior is present.

from msw.

louislebrault avatar louislebrault commented on September 27, 2024

To add some context, formData is part of a convention concerning the implementation of file upload through a GraphQL API : https://github.com/jaydenseric/graphql-multipart-request-spec

from msw.

kettanaito avatar kettanaito commented on September 27, 2024

Thanks for reporting this. There was a bug in Node.js v18 related to FormData but it was since fixed and should not be an issue on the latest v18.19.0. Wonder what makes this happen on Node.js v21.

It's worth noting MSW does nothing with FormData. It's likely that if something hangs, the issue is in the FormData itself. I recommend making sure you are not using any JSDOM and run a proper Node.js environment to A/B this behavior.

from msw.

kettanaito avatar kettanaito commented on September 27, 2024

Note: interestingly, doesn't hang on Vitest.

from msw.

kettanaito avatar kettanaito commented on September 27, 2024

Root cause

This appears to be a bug in Node.js. If you run this in Node, no MSW involved, the process hangs forever on cloning the Request with a FormData body:

const data = new FormData()
data.set('foo', 'ar')

const request = new Request('http://localhost', { method: 'POST', body: data })
request.clone()
console.log('cloned')

Replace the body with any other value, the request gets clone and the process exists normally.

Reproducible on:

  • v18.19.0
  • v20.11.0
  • v21.7.1

Filed as a bug in Node.js: nodejs/node#52167. Please follow the resolution of that issue there. Thanks.

from msw.

kettanaito avatar kettanaito commented on September 27, 2024

Also this: #1843 and this nodejs/undici#2413.

from msw.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.