Code Monkey home page Code Monkey logo

Comments (10)

kettanaito avatar kettanaito commented on June 25, 2024 1

Hi, @Tenga. Thanks for letting me know!

I'd love to use this suggestion but it doesn't seem to work in the boundary implementation:

Screenshot 2024-03-18 at 18 35 36

T & Function is not guaranteed to be a function. I can use some help with this. @Andarist, if you have a moment, do you see something wrong with what I'm doing? The behavior is reproducible in #2100, pnpm build. Thank you.

from msw.

kettanaito avatar kettanaito commented on June 25, 2024 1

Released: v2.2.9 🎉

This has been released in v2.2.9!

Make sure to always update to the latest version (npm i msw@latest) to get the newest features and bug fixes.


Predictable release automation by @ossjs/release.

from msw.

Andarist avatar Andarist commented on June 25, 2024 1

That doesn't look like an explicit type annotation but rather like an inlay hint

from msw.

Tenga avatar Tenga commented on June 25, 2024

Thanks for looking into this, both of you!

I just got around to updating MSW to 2.2.12. Unfortunately the changes had no effect on this issue on my end.

Screenshot 2024-03-27 at 17 11 32

Parameters are still any unless manually provided to boundary.

I'm on [email protected][email protected]. Are there any tsconfig settings needed to make this be correctly infered?

If not, can we reopen this or is the only other resolution to wait for the typescript to fix the issue linked in the first post?

from msw.

kettanaito avatar kettanaito commented on June 25, 2024

@Tenga, are you certain you aren't using TS 4.3? MSW doesn't support any TypeScript versions older than 4.7.

from msw.

Tenga avatar Tenga commented on June 25, 2024

@Tenga, are you certain you aren't using TS 4.3? MSW doesn't support any TypeScript versions older than 4.7.

@kettanaito Sorry, yeah I mistyped that somehow. The project (and VS Code) is using [email protected].

from msw.

Andarist avatar Andarist commented on June 25, 2024

could you share a repro case of the problem with the current version of MSW?

from msw.

Tenga avatar Tenga commented on June 25, 2024

@Andarist I've made a quick minimal repro repo that can be found here.

Below is what I get in the sample.test.ts in the project.

Screenshot 2024-03-27 at 19 08 13

The project and branch I've originally encountered this is here. Pardon the wild mess the branch is in, in case you decide to go looking. 😁

from msw.

kettanaito avatar kettanaito commented on June 25, 2024

@Tenga, in the code snippet above, I'm pretty sure expect is any because the entire argument is cast to any:

-({ expect }: any)
+({ expect })

Is there any difference if you omit any explicit types?

from msw.

Tenga avatar Tenga commented on June 25, 2024

Yup, @Andarist is correct, there is no explicit typing in the screenshot. Bright gray text is the VS Code inlay hints that I've enabled to show the inferred types clearly everywhere.

The source from the screenshot is identical to the code in the repro case I've provided in my previous post.

https://github.com/Tenga/msw-boundary-infer-repro/blob/main/sample.test.ts#L6

from msw.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.