Code Monkey home page Code Monkey logo

Comments (6)

lgordey avatar lgordey commented on June 29, 2024

Thank you for your feedback.
Fixed version will be released at the weekend I hope.

from webpack-svgstore-plugin.

fr-ench avatar fr-ench commented on June 29, 2024

@lgordey, thank you!

from webpack-svgstore-plugin.

lgordey avatar lgordey commented on June 29, 2024

@fr-ench Please, try fixed plugin version from branch - https://github.com/lgordey/webpack-svgstore-plugin/tree/feature/fix-paths-bug

from webpack-svgstore-plugin.

fr-ench avatar fr-ench commented on June 29, 2024

@lgordey,

For me it still doesn't look correct.
This lines of code
_fullPath = 'http://' + (baseUrl + '/' + url)
.replace(/^http:///, '')
.replace(//+/g, '/')
.replace(//+$/, '');

will product invalid url if baseUrl and publicPath are both undefined (baseUrl undefined) and url will start just with the domain name. The same problem happens if I define basicUrl that starts with "https://" because then I'll get https:/domain...
Why would you remove "http:"?

from webpack-svgstore-plugin.

lgordey avatar lgordey commented on June 29, 2024

@fr-ench Hi!
Try 2.1.4 version

from webpack-svgstore-plugin.

lgordey avatar lgordey commented on June 29, 2024

@fr-ench Tell me please if the problem is still relevant.

from webpack-svgstore-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.