Code Monkey home page Code Monkey logo

Comments (14)

efstathiosntonas avatar efstathiosntonas commented on May 23, 2024 1

when I removed the fps prop the issue went away.

from react-native-vision-camera.

mrousavy avatar mrousavy commented on May 23, 2024 1

Thanks for the bug report, but the reproduceable code is way too much. Can you please try to reproduce it in the example app instead?

from react-native-vision-camera.

mrousavy avatar mrousavy commented on May 23, 2024 1

Technically not, null means it won't set AE_EXPOSURE_DURATION, whereas 30 means it will set it to 30.

from react-native-vision-camera.

mrousavy avatar mrousavy commented on May 23, 2024 1

Yea okay, then it definitely is the same issue that I am already aware of. It's so lame that Samsung simply lies in CONTROL_AE_AVAILABLE_TARGET_FPS_RANGES - it contains 60 FPS, but doesn't actually support 60 FPS.

from react-native-vision-camera.

efstathiosntonas avatar efstathiosntonas commented on May 23, 2024

hi, it's happening on example too, I've tested it against Samsung S22 Android 14.

edit: tested it on beta 3

from react-native-vision-camera.

mrousavy avatar mrousavy commented on May 23, 2024

Okay yea I just read your comment about fps - I know about this issue, and I honestly don't know what to do here. Samsung is saying their phones can do 60 FPS in the API, but when you try to use 60 FPS it crashes.
They are messing it up here, there's nothing I can do except explicitly disabling 60 FPS on Samsung devices.

Just to clarify; does it also crash if just set fps={30}, or only something higher than 30?

from react-native-vision-camera.

efstathiosntonas avatar efstathiosntonas commented on May 23, 2024

thanks for the heads up, will check with 30 in a while but it should be the default if the prop isn't provided, right?

from react-native-vision-camera.

efstathiosntonas avatar efstathiosntonas commented on May 23, 2024

fps={30} won't crash it.

from react-native-vision-camera.

efstathiosntonas avatar efstathiosntonas commented on May 23, 2024

I wished they were lame only on that part lol!

I think the issue title should be ...in front camera

from react-native-vision-camera.

mrousavy avatar mrousavy commented on May 23, 2024

Just to double check if I am understanding this correctly - all values listed here are supported, right? Or only values here, that are also in CamcorderProfile.videoFrameRate?

Screenshot 2024-02-13 at 15 38 52

from react-native-vision-camera.

mrousavy avatar mrousavy commented on May 23, 2024

Can you try with a really low res format and see if that works at 60 FPS?

const format = useCameraFormat(device, [
  { videoResolution: { width: 100, height: 100 }
])

from react-native-vision-camera.

efstathiosntonas avatar efstathiosntonas commented on May 23, 2024

on back camera it throwed this:

fps={60}

 ERROR  [format/invalid-fps: [format/invalid-fps] The given format cannot run at 60 FPS! Make sure your FPS is lower than `format.maxFps` but higher than `format.minFps`.]

when switching to front no error but the screen is black, tried setting format to 400x400, same thing.

from react-native-vision-camera.

mrousavy avatar mrousavy commented on May 23, 2024

Hey - I just released VisionCamera 3.9.0-beta.4 which probably fixes this issue - can you try that latest beta and let me know? :)

from react-native-vision-camera.

efstathiosntonas avatar efstathiosntonas commented on May 23, 2024

it wont crash after setting fps to 60. Thanks Marc, keep it up!

from react-native-vision-camera.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.