Renaming a model attribute or deleting an attribute and creating a new attribute with the same args of the deleted one about prisma-ast HOT 4 CLOSED

Hi @abrl91,

You're right, the API isn't very clear about this. The .then() function is always going to return the current subject of the builder.

Subjects can only be nodes that can contain other nodes, such as models which can contain fields or attributes, or fields which can contain attributes. An attribute never becomes the current subject because it doesn't contain anything else. However, I agree that it isn't very satisfying from a user perspective for the builder to make this distinction. It would be nice for the TypeScript system to automatically assign the type of the current subject to .then() so that you would at least know what type you were receiving, but I couldn't figure out how to make that work.

These are the kinds of kinks that I want to make sure are worked out of the interface before releasing v1 of the library, and I'm open to suggestions for how it can be improved.

.removeAttribute() similarly, is expecting to target field attributes, not model attributes. Although I don't think there's any technical reason why it couldn't support both. That would be a good enhancement.

In the meantime, I think this would achieve the effect you're seeking:

    builder.model(model.name).then<Model>((model) => {
      for (const prop of model.properties) {
        if (prop.type === 'attribute' && prop.name === ID_ATTRIBUTE_NAME) {
          prop.name = UNIQUE_ATTRIBUTE_NAME;
          return;
        }
      }
    });

from prisma-ast.

@MrLeebo Thank you, it works!

from prisma-ast.

Hi @abrl91,

You're right, the API isn't very clear about this. The .then() function is always going to return the current subject of the builder.

Subjects can only be nodes that can contain other nodes, such as models which can contain fields or attributes, or fields which can contain attributes. An attribute never becomes the current subject because it doesn't contain anything else. However, I agree that it isn't very satisfying from a user perspective for the builder to make this distinction. It would be nice for the TypeScript system to automatically assign the type of the current subject to .then() so that you would at least know what type you were receiving, but I couldn't figure out how to make that work.

These are the kinds of kinks that I want to make sure are worked out of the interface before releasing v1 of the library, and I'm open to suggestions for how it can be improved.

.removeAttribute() similarly, is expecting to target field attributes, not model attributes. Although I don't think there's any technical reason why it couldn't support both. That would be a good enhancement.

In the meantime, I think this would achieve the effect you're seeking:

    builder.model(model.name).then<Model>((model) => {
      for (const prop of model.properties) {
        if (prop.type === 'attribute' && prop.name === ID_ATTRIBUTE_NAME) {
          prop.name = UNIQUE_ATTRIBUTE_NAME;
          return;
        }
      }
    });

The issue with the .then() was confusing because it seems like the subject can get Block or Property

About removeAttribute() - I know it is only for a field attribute. I just wrote it as a pseudo code to emphasize what I am trying to do.

BTW, we use your library for a very important feature (in Amplication), and I must say that it really helps us and it is very easy to use and understand.

from prisma-ast.

The issue with the .then() was confusing because it seems like the subject can get Block or Property

Yeah, that type definition is too broad. It should be schema.Block | schema.Field

from prisma-ast.