Comments (5)
mrjones
commented on July 19, 2024
Thanks so much for the report!
The brief summary is that PostForm method wasn't correctly signing requests.
I've fixed the signing, and also just merged Post() and PostForm():
- PostForm is just a wrapper for Post can be deleted soon.
- POST now just passes the key-value pairs in the body (x/application-www-form-urlencoded), and I've removed the option to pass data in the URL for a POST since in retrospect that seems wrong (GET will still put ket-values in the URL).
I've also fixed the twitter example (the posting is now controlled by a flag rather than being commented out).
(cc: @ranveerkunal Could you confirm that the new version of Post() works for you whenever you have a minute? Thanks!)
I'm going to close this, but definitely feel free to re-open it or file a new one if anything isn't working!
- Matt
from oauth.
robfig
commented on July 19, 2024
Works, thank you!
The only note is that right now you are sending the consumerKey as a parameter in PostForm, but that is not necessary.
from oauth.
mrjones
commented on July 19, 2024
Indeed, you're right. Fixed up the example.
from oauth.
ranveerkunal
commented on July 19, 2024
I am also good !
@rob Are you the same Rob I know?
On Mon, Nov 5, 2012 at 1:10 AM, Matt Jones [email protected] wrote:
Indeed, you're right. Fixed up the example.
—
Reply to this email directly or view it on GitHubhttps://github.com//issues/2#issuecomment-10059534.
Ranveer Kunal | Software Engineer | [email protected] | +55 31 93135963
from oauth.
robfig
commented on July 19, 2024
Hey, yea, how's it going :~)
from oauth.
Related Issues (20)
- Add more structure to errors HOT 3
- Using "UnixNano" as a random seed HOT 1
- Seems Twitter auth doesn't work without oob but with callback url HOT 2
- RSA private key cannot be defined HOT 5
- broken request if parameter contains ";" HOT 4
- Verifying requests HOT 1
- Error reading privateKey HOT 2
- Would like to patch so that Oauth works with Yahoo. Preferred Way? HOT 8
- Space not properly escaped HOT 1
- Twitter example doesn't work HOT 1
- No license HOT 1
- Not working for Twitter
- Does this library work with one legged authorization? HOT 7
- Not able to make OAUTH Post call HOT 2
- The logic behind preventing multiple form parameters with same name. HOT 5
- HTTP/S Proxy Support HOT 2
- Consider merging with Gomniauth
- Renew access token HOT 1
- Consider rename to `LICENSE.txt`
- Return HTTP response to clients even on non 2XX responses. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from oauth.