Code Monkey home page Code Monkey logo

Comments (4)

spudwebb avatar spudwebb commented on May 29, 2024

Task.Run does not allow to pass TaskCreationOptions.LongRunning, so shouldn't we use Task.Factory.StartNew instead?

also there is the same problem here:

ZigbeeNet/libraries/ZigBeeNet.Transport.SerialPort/ZigBeeSerialPort.cs

Lines 99 to 102 in 065fc7f

// Start Reader Task
_reader = new Task(ReaderTask, _cancellationToken.Token);
_reader.Start();

from zigbeenet.

nicolaiw avatar nicolaiw commented on May 29, 2024

ur right .. this should be changed as well .. I would agree .. StartNew() would be an option .. another topic is the call to Task.Result in this project .. this should be avoided ..

from zigbeenet.

spudwebb avatar spudwebb commented on May 29, 2024

fixed in PR #90

from zigbeenet.

Mr-Markus avatar Mr-Markus commented on May 29, 2024

Good improvement

from zigbeenet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.