Logger Interface about zigbeenet HOT 5 CLOSED

I think that is not necessary. Serilog already has many sinks and is therefore very flexible. I think we should not reinvent the wheel here. However, I would offer the caller the possibility to pass a logger configuration which is currently hardcoded in CCZnp.Init().

from zigbeenet.

LibLog is made for the purpose.

from zigbeenet.

I just had a look at LibLog and it seems to be exactly what we are looking for.

@Mr-Markus do you agree ?

from zigbeenet.

using System;
using Serilog;

namespace` ZigbeeNet.PlayGround
{
    class Program
    {
        static void Main(string[] args)
        {
            // Configure Serilog
            Log.Logger = new LoggerConfiguration()
               .MinimumLevel.Debug()
               .WriteTo.Console()
               .CreateLogger();

            try
            {
                var zigbeeService = new ZigbeeService(new Options { Baudrate = 115200, Port = "COM3" });
                zigbeeService.Start();
            }
            catch (Exception ex)
            {
                Console.WriteLine(ex.ToString());
            }

            Console.ReadLine();
        }
    }
}

will now produce something like:

I removed all dependencies of Serilog and instead added LibLog. (@eiaro thanks for your advice). Now the user of the lib can decide which framework to use or even write a custom logger.

@Mr-Markus something happend that should not :) .. I unintentionally pulled directly to the project instead of sending a pull request. Sry for that! To avoid this in the future pls remove me as a contributor so that I can't pull directly to this repo.

from zigbeenet.

Yes, exactly what we were looking for!

Thanks for Suggestion @eiaro and thanks to @nicolaiw for implementation

@nicolaiw
Ok, i would remove you from the collaborator list and you can create pullrequests for your changes :)

Because of that i will close the issue. Thanks!

from zigbeenet.