Error message styling about donate-wagtail HOT 10 CLOSED

@beccaklam It feels like this is related to MozillaFoundation/Design#344, which it seems we punted on but is pretty important to figure out at this point.

from donate-wagtail.

Hi @philwakefield and @alanmoo I updated the details/payment form with an error state yesterday. Do you need any more styling direction than that? https://goo.gl/maps/GFsgz1vu1jjZm3Gx9

from donate-wagtail.

@nicklee more elaboration on error messaging. Can we change the required field error message to match below? https://redpen.io/gp440d547455ba6f63

from donate-wagtail.

Hi @beccaklam, thanks for this, the required star is shown on the normal form, before validation has occured, we don't seem to have an indication as to which fields are required in the designs, is this intentional?

We only get a single "this field is required" validation message with the current setup, I've styled this to get it as close to your designs as possible (error message at the top is larger size due to this being on mobile):

from donate-wagtail.

Sorry @nicklee, I know you've asked this question a couple times. Below should be the styling for any required field but in my opinion we should only be asking for required fields to cut down on form fatigue. Therefore it seemed a bit redundant to denote which were required fields since they all should be ... but @alanmoo do you know which ones are required and which ones are superfluous but we use for communication purposes?

from donate-wagtail.

I'm like 99% sure all fields are required. @solarissmoke would be able to definitively answer if the API doesn't require one of them...I suppose first name isn't technically required from a basket standpoint, but Braintree probably needs it.

from donate-wagtail.

Actually none of these fields are required by Braintree - it's possible to create an anonymous customer. But:

1. We'd probably want at least an email address to be able to identify the customer in Braintree.
2. Address information is needed if you want to be able to do address verification on cards. This might be something to discuss with Braintree - the documentation doesn't seem to recommend this, but it might mitigate carding attacks.

from donate-wagtail.

We definitely want email to send receipts.

@WillatMozFdn Do we collect address to mitigate fraud?

from donate-wagtail.

@alanmoo -- yes, mailing address is an important piece of our anti-fraud efforts, and my pretty strong feeling is that we WILL want to enable AVS. Our fraudsters are pretty relentless. Overall we should plan to take advantage of any and all tools that Braintree offers to help shut them down, even if it means rejecting some potentially legitimate donations.

from donate-wagtail.

This was resolved

from donate-wagtail.