Code Monkey home page Code Monkey logo

Comments (3)

KZeni avatar KZeni commented on May 24, 2024

This was my first thought when I saw what the reasons for the service being taken down temporarily. They might be doing more than this, but I definitely think it makes sense that this is also made to be a part of it.

#91 (comment) has me thinking there has been hesitation in the past regarding this based on wanting to know as little as possible about the files/data being uploaded. However, we need to know if what's being uploaded is malicious (hence the temporary shutdown of the service.) Checking (not needing to store it or anything) the hash of the unencrypted file to then check with VirusTotal isn't much of a privacy concession if it then helps prevent the spread of malicious payloads.

from send.

reinhart1010 avatar reinhart1010 commented on May 24, 2024

Just to be clear, files that one is trying to upload at Firefox Send should not be uploaded to VirusTotal, just before uploading to Firefox Send, the has(md5/sha512), should be calculated, and VirusTotal should be queried if the file is know there, and if the file is a Virus.

It might be a better idea to also directly include an antivirus engine, such as ClamAV to inspect the uploaded files. Chances are that one virus infect multiple files, which gives unique hashes which could remain undetectable on VirusTotal.

from send.

santrancisco avatar santrancisco commented on May 24, 2024

Or checking it on download :) I recently built something similar to firefoxsend but much much simpler in design with just a github page, a single lambda function, apigateway and an s3 bucket https://www.relaysecret.com . I just added virustotal check today, thanks for the idea @blade1989 . The code is opensource in my github and I would love to get some feedbacks :)

from send.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.