Clicking a suggestion == query should be like clicking next about prospector HOT 7 CLOSED

Patch: erikvold/prospector@55b6ec1

from prospector.

My first thought is that, after clicking a word, it should:

1. be added to the find field
2. removed from the suggestion list, since the user has confirmed it is the desired word

from prospector.

you say the word should be removed, but I don't see a reason.

removed from the suggestion list, since the user has confirmed it is the desired word

This sounds like the reason to do step 1, but not a reason to do step 2.

if (word === lowerQuery || word.slice(0, queryLen) != lowerQuery)

This would mean that when a user types "dog" that they won't see confirmation that "dog" is on the page, if it is on the page.

from prospector.

Oops, sorry. Hadn't had my coffee yet :) Will check it out this afternoon.

If the purpose is to predict the next word, it wouldn't make sense to keep a user-confirmed word in the list. Maybe words that have word as a prefix.

• from my phone

from prospector.

What erikvold suggested was correct in that the words in the list provide a sanity check that the particular word is in the page. This is partially because search is still doing "match anywhere" while the suggestions are prefix matches.

from prospector.

Okay, I had been thinking of something like Swiftkey (Android).

from prospector.

Closed by 1646898: findSuggest: Clicking a suggestion == query should be like clicking next [r=Mardak]
Clicking a suggestion == query should be like clicking next
(cherry picked from commit 55b6ec1c36289edbe5626c48d3be3e0004a091b5)

from prospector.