Code Monkey home page Code Monkey logo

Comments (7)

vincentfretin avatar vincentfretin commented on September 7, 2024

Comparing to the others solutions, this is somewhat similar to janus videoroom plugin I guess, but videoroom plugin is hard coding 5 publishers maximum (was 3 previously).
Hubs moved to dialog/mediasoup and is able now to have a lobby with 75 subscribers in the lobby listening to the publishers' audio, and 24 publishers in the room.

from janus-plugin-sfu.

mqp avatar mqp commented on September 7, 2024

You're definitely right that currently the code assumes that every user will have a publisher which is sort of the "master" connection for that user, or else things don't make much sense.

This sounds like a fine idea, but I'm kind of hesitant to put a lot of work into it until the Janus multistream changes are live, because everything would change dramatically.

from janus-plugin-sfu.

mqp avatar mqp commented on September 7, 2024

(In general, once multistream is in, I'm open to doing a bunch of work to refit the plugin to your needs and to anyone else's needs who is interested in it, now that Hubs moved away from it -- it will depend on how much demand there is and how cool I think your projects are. But until then I am not really motivated to make big changes. Of course, in the meantime, I am happy to answer questions, help review any changes you make, etc.)

from janus-plugin-sfu.

vincentfretin avatar vincentfretin commented on September 7, 2024

I'm not asking you to do all the work @mqp :-)
I'm glad you did all the changes recently and answered my questions. A big thanks for that!
I want mainly to start a conversation here and see if there is an interest for others. If I really need it, I'll start to learn rust more seriously. ;-)
I agree this use case can include some important changes.
It depends of the use case, but having a publisher broadcasting in several rooms may have simpler changes and others are interested in it #55

from janus-plugin-sfu.

vincentfretin avatar vincentfretin commented on September 7, 2024

About my comment "And we can't currently use process_subscribe without knowing the occupantId that is returned in the response of using process_join as a publisher..."
Not entirely true if you use an external users source like Phoenix Presence like it was the case for Hubs.

If you use an external users source, you can already use process_subscribe to have listeners only in the room and without security check if I understand it correctly.

from janus-plugin-sfu.

vincentfretin avatar vincentfretin commented on September 7, 2024

I confirm you can use today the subscribe message that will call process_subscribe and it doesn't check security, see my comment
#81 (comment)

from janus-plugin-sfu.

vincentfretin avatar vincentfretin commented on September 7, 2024

More detailed thinking about this use case in the PR networked-aframe#6

from janus-plugin-sfu.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.