Get grcov working on Mozilla's "build" type one-click loaners about grcov HOT 7 CLOSED

For the GLIBC issue, there are two options:

1. compile and distribute grcov as a standalone binary (using musl instead of glibc);
2. compile grcov on one of the loaner machines, so that the binary links to the libc version that's available on those machines.

It should definitely be possible to support older versions of gcc.

from grcov.

Could you try this binary (with the PATH modified to use gcc 4.9.4):
grcov.zip

from grcov.

The provided grcov binary runs.

I also tried running code-coverage.py and it yields a report successfully: https://github.com/mjzffr/ccov-reports/tree/master/grcov-one-click-240417-f170ebfc2dfd/report

FYI: when using --no-download on the one-click loaner I get an empty output.info on the one-click loaner (although this works fine locally when I place the same gcda/gcno zip files in ccov-artifacts).

python firefox-code-coverage/code-coverage.py workspace/build/src $MH_BRANCH $GECKO_HEAD_REV --grcov ./grcov --no-download
Running grcov... 0
Reading data file /home/worker/output.info
genhtml: ERROR: no valid records found in tracefile /home/worker/output.info
Traceback (most recent call last):
  File "firefox-code-coverage/code-coverage.py", line 147, in <module>
    main()
  File "firefox-code-coverage/code-coverage.py", line 143, in main
    generate_report(os.path.abspath(args.src_dir))
  File "firefox-code-coverage/code-coverage.py", line 111, in generate_report
    raise Exception("Error while running genhtml.")
Exception: Error while running genhtml.
(grcov) [root@6ad4646442bd ~]# cat output.info 
TN:

from grcov.

I also tried running code-coverage.py and it yields a report successfully: https://github.com/mjzffr/ccov-reports/tree/master/grcov-one-click-240417-f170ebfc2dfd/report

Awesome, so from now on, whenever I release a new grcov version I can simply provide a standalone binary on https://github.com/marco-c/grcov/releases/latest.

FYI: when using --no-download on the one-click loaner I get an empty output.info on the one-click loaner (although this works fine locally when I place the same gcda/gcno zip files in ccov-artifacts).

Is the ccov-artifacts directory you manually created in your working dir?
Here's the code that lists the artifacts:
https://github.com/marco-c/firefox-code-coverage/blob/master/code-coverage.py#L81

from grcov.

Is the ccov-artifacts directory you manually created in your working dir?
Here's the code that lists the artifacts:
https://github.com/marco-c/firefox-code-coverage/blob/master/code-coverage.py#L81

Perhaps it would be better to modify the parameter --no-download into --with-artifacts=PATH_TO_ARTIFACTS to avoid issues.

from grcov.

Yes, it was in my working dir.

Changing to --with-artifacts is a good idea, either way.

from grcov.

I opened #22 to support GCC < 4.9.0 (even though at this point it isn't strictly required, as we can just set the PATH to use GCC 4.9.4) and mozilla/firefox-code-coverage#4 to support --with-artifacts instead of --no-download (but on a one-click-loaner I guess it's easier for users to just let the script download the artifacts).

from grcov.