/settings page blank while the avatar loads about fxa HOT 7 CLOSED

I see, a call to /v1/profile on the profile server calls /v1/avatar. The initial avatar load takes 5+ seconds, then a second fetch occurs for just the avatar data, adding 5 more seconds.

This is sub-optimal. The profile data fetch done in settings.js->beforeRender already returns the avatar data, the call to /v1/avatar from account.fetchCurrentProfileImage in settings.js->afterVisible fetches no new information and only is only used to fetch the avatar id and slows down the perceived load time.

I wonder if we can speed this up using two approaches:

1. Ditch the redundant call to /v1/avatar
2. Call account.fetchProfile() in afterVisible

The first seems relatively safe, the second I'm unsure of the repercussions.

cc @zaach, @jstrutz

from fxa.

Ref #2980

from fxa.

This is a partial dup of #2980.

from fxa.

More info - the call to /v1/avatar may be done because /v1/profile only returns the avatar URL and not the avatar ID. The avatar ID I believe is necessary to delete the avatar, but loading /settings/avatar/change fetches the avatar again anyways, which will get the ID.

The call to /v1/profile could return the avatar id to eliminate the necessity of fetching the avatar information again when hitting /settings/avatar/change.

from fxa.

👍 to fix this, speed boost for functional tests :)

from fxa.

from mtg: the new spinner might make this experience better

from fxa.

We tested this in triage and I think it is fixed. A full refresh will show the settings page immediately with a blank avatar, and then the avatar is shown (after it downloads, presumably).

from fxa.