Code Monkey home page Code Monkey logo

Comments (9)

pdehaan avatar pdehaan commented on May 31, 2024

Related: #41 (which I should really do something about since my dumb face is on the ticket).

Also, we should look at ignoring Node 4.x failures until we are confident that Node 4 works for our projects. Something like this pseudo code from fxa-auth-db-server:

matrix:
  allow_failures:
    - node_js: 4
  fast_finish: true

from fxa.

jrgm avatar jrgm commented on May 31, 2024
node_js:
  - "0.10"
  - "0.12"
  - "4"

I'm happy with that. And @pdehaan's suggestion is good, but if a module just doesn't compile on 4.0, then testing on 2.0 is better than just spinning travis-ci on some dependency known to fail on 4.0 due to not being updated for NAN 2.0.

from fxa.

shane-tomlinson avatar shane-tomlinson commented on May 31, 2024

Backlogged until all of our modules compile on node 4

from fxa.

pdehaan avatar pdehaan commented on May 31, 2024

Saw this over the weekend: https://twitter.com/seldo/status/646463678410174465
Seems to be some decent justification that we shouldn't really care about testing on io.js.

Major(ish) node versions, requests in last 7 days:

VERSION REQUESTS
0.12 779 MM
0.10 732 MM
4 222 MM
2 (iojs) 22 MM
3 (iojs) 19 MM
1 (iojs) 6 MM

from fxa.

rfk avatar rfk commented on May 31, 2024

Backlogged until all of our modules compile on node 4

What are the known blockers?

from fxa.

jrgm avatar jrgm commented on May 31, 2024

What are the known blockers?

One is updating for @dannycoates' scrypt-hash fix.

from fxa.

rfk avatar rfk commented on May 31, 2024

IIUC from a chat with Danny in IRC, scrypt-hash should be ready to go as of its latest release.

from fxa.

rfk avatar rfk commented on May 31, 2024

Which re-reading your comment, is probably what you meant by "@dannycoates' scrypt-hash fix", never mind me...

from fxa.

vladikoff avatar vladikoff commented on May 31, 2024

Pretty much fixed with the node 4 updates

from fxa.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.