Comments (9)
Related: #41 (which I should really do something about since my dumb face is on the ticket).
Also, we should look at ignoring Node 4.x failures until we are confident that Node 4 works for our projects. Something like this pseudo code from fxa-auth-db-server:
matrix:
allow_failures:
- node_js: 4
fast_finish: true
from fxa.
node_js:
- "0.10"
- "0.12"
- "4"
I'm happy with that. And @pdehaan's suggestion is good, but if a module just doesn't compile on 4.0, then testing on 2.0 is better than just spinning travis-ci on some dependency known to fail on 4.0 due to not being updated for NAN 2.0.
from fxa.
Backlogged until all of our modules compile on node 4
from fxa.
Saw this over the weekend: https://twitter.com/seldo/status/646463678410174465
Seems to be some decent justification that we shouldn't really care about testing on io.js.
Major(ish) node versions, requests in last 7 days:
VERSION REQUESTS 0.12 779 MM 0.10 732 MM 4 222 MM 2 (iojs) 22 MM 3 (iojs) 19 MM 1 (iojs) 6 MM
from fxa.
Backlogged until all of our modules compile on node 4
What are the known blockers?
from fxa.
What are the known blockers?
One is updating for @dannycoates' scrypt-hash fix.
from fxa.
IIUC from a chat with Danny in IRC, scrypt-hash should be ready to go as of its latest release.
from fxa.
Which re-reading your comment, is probably what you meant by "@dannycoates' scrypt-hash fix", never mind me...
from fxa.
Pretty much fixed with the node 4 updates
from fxa.
Related Issues (20)
- English string "Or download" displayed in Danish Firefox Accounts HOT 1
- Update enabled locales list to include Friulian (fur) HOT 1
- The user is not redirected back to AMO after reset password
- "Device Connected" page, the text on the button becomes unreadable blue-text-on-blue-background when clicked ("See tabs from synced devices") due to insufficient contrast HOT 6
- Cannot unsubscribe from Firefox Account Tips HOT 4
- Readme and documentation needs to use updated "Mozilla accounts" branding HOT 4
- Avatar is clipped on subscriptions page, due to explicit `w-16 h-16` classes HOT 4
- Subscription management page uses CSS file with broken/out-of-date source map HOT 1
- Layout shift after you open Bento Menu at top right of Mozilla Accounts page HOT 5
- The Sync sign-in success page just says "Sign in to this Firefox to complete set-up" without any other context (if you're not signed in) HOT 3
- The column of time/datestamps need a label/title to clarify their meaning, in the Connected Services section of settings
- On the "Approval now required" card at the end of the firefox.com/pair flow, the "from your other device" text is styled to be extra-small, despite being fairly-important HOT 1
- No graphic on on the "Approval now required" card at the end of the firefox.com/pair flow, HOT 2
- If the firefox.com/pair process times out and reaches "Pairing not successful", the user should be able to restart the pairing process with an offered button or link, or a reload HOT 2
- (l10n) - Duplicate string IDs
- Research @nx/playwright HOT 1
- accounts.firefox.com sends two HSTS headers HOT 5
- fxa-auth-server mock statsd lacks of function histogram
- (l10n) productPaymentCycleNew and productPaymentCycleOld are hard-coded to English HOT 1
- While subscriptions.firefox.com is loading, it shows a zero-height empty "card" while the loading throbber/spinner is still animating HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fxa.