Code Monkey home page Code Monkey logo

Comments (3)

willkg avatar willkg commented on June 14, 2024

There's a single call in the elasticutils.contrib.django:S class. I'm not sure I'd say it was supported.

If anything, it should be taken out. There are a couple of reasons for this:

  1. statsd takes an application and an action name and we've hardcoded that which sucks. We could expose that via settings, but I don't think it's a good balance of convenience for users vs. added maintenance for elasticutils
  2. if you look at the place where it gets used, it's easily done in the code using elasticutils

Anyhow, so... I'm going to turn this bug around into a "remove statsd" bug and instead add notes to the documentation about wrapping important bits with statsd calls.

from elasticutils.

almet avatar almet commented on June 14, 2024

Makes sense. +1 for removal, letting the code using EU deal with statsd themselves.

from elasticutils.

willkg avatar willkg commented on June 14, 2024

I nixed statsd code with the changes in 6ccf9dd.

from elasticutils.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.