Comments (11)
Does it work for you here? http://alicoding.github.io/call-congress-net-neutrality/ @simonwex I've tested and it's working both in Firefox and Chrome with Private mode as well.
from call.mozilla.org.
@alicoding Used your link and it happens to me when I focus the input field, add nothing, then hit 'tab' to defocus the field. In chrome.
from call.mozilla.org.
Ah, good catch @flukeout it's the defocusing of the input field.
from call.mozilla.org.
Ah I can see that now too!
from call.mozilla.org.
^ Updated title
from call.mozilla.org.
Hmm... Apparently it will error when press tab or shift+tab (next or previous field). I wonder if this is because of the jquery-mask plugin, but it doesn't break anything here (Thanks god!).
I'm going to look into this and see what is wrong.
from call.mozilla.org.
Some minor points
- The magic formatting breaks things when you add a non-number character in the middle of the phone number (like might happen when you're editing a bad number) - it erases everything after the bad character
- I'm unable to Command+A (select all) to select the phone number after I've added it unless I do it very slowly
- When I focus the field, the cursor for typed text appears in the middle of the phone number because it's centered, it's a bit weird - I think left aligning the text would be OK here
- Should we auto-focus the input field on desktop?
- Feels weird when you don't add a number and hit the button and there's a spinner "thinking" aobut your number. It should just instantly say "please add a number" (the 'check the number again' wording is also a little weird)
- If you type an illegal character as your first digit, the auto-formatting breaks and skips the (555) brackets portion of the input
@simonwex @alicoding Sorry guys I realized I'm spamming this particular ticket with a bunch of QA stuff, are you interested in this kind of feedback in another ticket or issue?
from call.mozilla.org.
@simonwex #7 so we don't need those at all \o/
from call.mozilla.org.
@flukeout I've fixed this
- fixed the non number break format
from call.mozilla.org.
The Command-A
(Select all) is not doable with this plugin, but there is another one except the file size for that plugin is huge (50kb vs 5kb)
This one is better but too big https://github.com/RobinHerbots/jquery.inputmask
This one is the one we are using right now http://igorescobar.github.io/jQuery-Mask-Plugin/
I've fixed the text cursor.
from call.mozilla.org.
Now only two things we can't fix until we can come up with our own quick mask
js hack or choose different plugin here @flukeout @simonwex for Select all I mean.
from call.mozilla.org.
Related Issues (20)
- Fix typos on script screen HOT 2
- Got "we have encountered an error - goodbye" HOT 2
- Don't lose the phone # when i preview the script
- while calling, the call script bubble colour is off HOT 2
- Replace twilio logo png with svg
- Fix alignment issues inside the text field
- 'get started' button text should be Light
- Fix desktop footer padding
- Tweak countdown box styling
- Add Countdown box's shadow HOT 3
- Center 'preview link' underneath the button HOT 1
- Increase "The FCC votes on Net Neutrality in..." text to 50px
- Move moz logo in (set page container width) HOT 1
- Fix alignment inside preview box
- Make call preview box wider
- Fix spacing issues on "calling now" screen
- Change query string for campaign
- Minor text changes to Report Back UX HOT 1
- License?
- CODE_OF_CONDUCT.md file missing
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from call.mozilla.org.