Comments (7)
At
Line 302 in 008c34b
So, for example xul.dll should still be xul.dll and not replaced with DLL_NAME. Same with mozglue.dll, libxul.so, and so on.
To get all Firefox DLLs, you can either download the archives containing the Firefox binaries from a URL such as https://ftp.mozilla.org/pub/firefox/nightly/2019/02/2019-02-27-10-44-26-mozilla-central/ (firefox-67.0a1.en-US.win64.zip, firefox-67.0a1.en-US.mac.dmg, firefox-67.0a1.en-US.linux-x86_64.tar.bz2), or install Firefox on the different OSes, go in the installation directory and check which DLLs are present.
from bugbug.
I would like to take this up. Could I be assigned?
from bugbug.
@LakshyAAAgrawal feel free to work on any open issue. See https://github.com/mozilla/bugbug#contributing, all issues are unassigned until there is a PR open to fix them.
from bugbug.
Could I create a file "firefox_DLLs.json" which contains a list of all firefox library files including *.so and *.dll files, and then load this file when the function "cleanup_dll" is called, and then do the needful for differentiating?
from bugbug.
You can just hardcode the DLL names in a constant that you define right before cleanup_dll, a separate file is overkill.
from bugbug.
In the test file test_cleanup_functions.py, the second test asserts that 'libxul.so' gets converted to '__DLL_NAME__', as shown:
def test_cleanup_dll():
tests = [
('Crashing thread: 0 scdetour.dll scdetour.dll@0x2dd77', 'Crashing thread: 0 __DLL_NAME__ __DLL_NAME__@0x2dd77'),
('Crash in libxul.so@0x287ad36 | libxul.so@0x270c062', 'Crash in __DLL_NAME__@0x287ad36 | __DLL_NAME__@0x270c062'),
('Crash in libsystem_pthread.dylib@0x14fc', 'Crash in __DLL_NAME__@0x14fc')
]
However, as pointed out above by @marco-c :
So, for example xul.dll should still be xul.dll and not replaced with '__DLL_NAME__'. Same with mozglue.dll, libxul.so, and so on.
Therefore, I think this test case should be updated. Am I missing something here?
from bugbug.
Yes, it should be updated.
from bugbug.
Related Issues (20)
- [model:bugtype] Fix the name for the performance impact field
- Refactor the logic in the `bug_to_types` function and extract it from the `bugtype` model file
- [model:performance] Experiment with including bugs with their performance impact is `none` in the training set only
- Integrate with Weights & Biases
- Create a pipeline to retrieve crash reports from BigQuery and make them available to the model training tasks
- Create a model to predict actionable crashes
- [model:stepstoreproduce] Training task exit with status code 137
- [model:regressor] AttributeError: 'IsotonicRegressionCalibrator' object has no attribute 'n_features_in_' HOT 2
- Refactor the way that we apply `CalibratedClassifierCV` to the models
- [model:performance] Experiment with including bugs from performance components in the training set only
- Add more detailed guidance and recommendations to CONTRIBUTING.md
- Remove duplicate imports for `dateutil.parser`
- [model:bugtype] The `Keywords` feature accepts keywords but is given keyword prefixes
- [model:performance] Add the model to `http_service` and `data_pipeline`
- [model:accessibility] Add the model to `http_service` and `data_pipeline`
- UnboundLocalError: local variable 'median_fix_time_text' referenced before assignment when generating quality report
- [model:bugtype] ValueError: y should be a 1d array, got an array of shape (198635, 5) instead.
- [model:bugtype] ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all() HOT 1
- Show the number of not classified instances for multi-label models HOT 1
- Include certain comment fields which will help the model to tag spam comments
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bugbug.