Code Monkey home page Code Monkey logo

Comments (6)

jashrathod avatar jashrathod commented on July 17, 2024

Hi.
I would like to work on this issue.
Previously I have not made any contributions to any open source community.
It would be great if you could help me get started.

from bugbug.

marco-c avatar marco-c commented on July 17, 2024

To fix this issue, we'll need to do something similar to 2a44029, but for the uplift model. We'd need to rollback to the time the uplift request was accepted or rejected.

from bugbug.

chidauri avatar chidauri commented on July 17, 2024

@marco-c How to test if i've made correct changes for this issue?

from bugbug.

marco-c avatar marco-c commented on July 17, 2024

@chidauri make sure you can run the model, and write some tests similar to those in #189.

from bugbug.

ayush1999 avatar ayush1999 commented on July 17, 2024

@marco-c The rollback should be done to the time when anything beginning with approval-mozilla was added to the change, right?

from bugbug.

marco-c avatar marco-c commented on July 17, 2024

We have to rollback to the time when the uplift was accepted (approval-mozilla-XXX == +) or rejected (approval-mozilla-XXX == -), but we don't have to rollback to when the uplift was requested (approval-mozilla-XXX == ?).

from bugbug.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.