Private browsing not able to enable/disable Blok about blok HOT 9 CLOSED

Damn, this is a regression on more than just PBM windows. I'll check it out.

from blok.

Hmm ... had trouble reproducing this behavior in DE ... but I found another bug

Steps to reproduce:

1. git checkout master
2. npm install
3. ./node_modules/.bin/web-ext run --firefox-binary=/Applications/FirefoxDeveloperEdition.app/Contents/MacOS/firefox-bin --firefox-profile=Blok
4. Open tulsaworld.com
5. See Blok toolbar
6. Click "Disable Blok on this site"
7. Page refreshes; Blok toolbar shows " Blok is disabled. Parts of this site my be tracking your activity. Enable Blok on this site."; a bunch more ads show
8. Click "Enable Blok on this site."
9. Page refreshes; Blok toolbar shows " Blok is enabled. It is blocking tracker requests on this site. Disable Blok for this website. "; a bunch of ads disappear
10. Open a PBM window
11. Go to tulsaworld.com
12. Blok toolbar shows " Blok is enabled. It is blocking tracker requests on this site. Disable Blok for this website. ";
13. Click "Disable Blok on this site"
14. The first (non-PBM) window refreshes!!

from blok.

@rbillings - what version of Blok does your about:addons show?

from blok.

FWIW, I sent #76 to fix the issue I found. Your issue may be related or caused by the same thing, so it may be worth trying this again after I merge that PR.

from blok.

extensions.bootstrappedAddons version = 2.0.17
I'll re-check after the PR is merged

from blok.

I merged #76 into master, and this seems to be fixed for me with version = 0.1.8. The issue wasn't PBM-specific; any new/2nd window failed to enable/disable Blok because I wasn't setting the active tab ID when window focus changed.

from blok.

@groovecoder how do I get the updated .xpi file for testing?

from blok.

Uplifting from IRC ...

rbillings: grab the latest .xpi from https://github.com/mozilla/blok/tree/master/web-ext-artifacts
10:24 AM <groovecoder> rbillings: working on a process this week that will create a -latest.xpi file, but it’s not done yet
10:30 AM <rbillings> groovecoder: thanks- the link in the README goes directly to the old version, so this is very helpful
10:31 AM <groovecoder> rbillings: yeah, sorry about that. pdehaan has a fix for that in https://github.com/mozilla/blok/pull/68/files

from blok.

Tested with the new .xpi file and everything looks good.

from blok.