<div class="snippet-clipboard-content notranslate position-relative overflow-auto" data-snippet-clip

Thanks <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-u

Currently brackets are again swallowed. For example: <div class="highlight highlig

Linkify eats brackets in inner text. about bleach HOT 5 CLOSED

mozilla commented on August 15, 2024

Linkify eats brackets in inner text.

from bleach.

Comments (5)

jsocol commented on August 15, 2024

I'm not sure I'm following. The example makes it look like linkify isn't picking up the link at all, e.g.:

>>> import bleach
>>> bleach.linkify('http://example.com/foo)')
u'http://example.com/foo)'

Is that correct?

from bleach.

SmileyChris commented on August 15, 2024

No, the issue is that the bracket is getting swallowed as part of the link, when most of the time it's more likely that it is part of plain text:

For example:

u'(<a href="http://example.com" rel="nofollow">example.com</a>)'

> > > bleach.linkify("(example.com/)")
> > > u'(<a href="http://example.com/)" rel="nofollow">example.com/)</a>'```

The decision just needs to be made as which one is more important to get right, since some urls _may_ end in a bracket. E.g.: http://en.wikipedia.org/wiki/Test_(assessment)

from bleach.

voidfiles commented on August 15, 2024

This is still an issue, here is an example.

In [18]: linkify('(http://www.google.com/)')
Out[18]: u'(http://www.google.com/)'

In [19]: linkify('(http://www.google.com/).')
Out[19]: u'(http://www.google.com/).'

from bleach.

jsocol commented on August 15, 2024

Thanks @voidfiles, I filled #49.

from bleach.

vitalyvolkov commented on August 15, 2024

Currently brackets are again swallowed. For example:

>>> import bleach
>>> bleach.linkify(u'Один из подходов нашего «пути китайского пионера» при вэб-разработке - backvendor (http://www.yiiframework.com/extension/backvendor/).')
u'\u041e\u0434\u0438\u043d \u0438\u0437 \u043f\u043e\u0434\u0445\u043e\u0434\u043e\u0432 \u043d\u0430\u0448\u0435\u0433\u043e \xab\u043f\u0443\u0442\u0438 \u043a\u0438\u0442\u0430\u0439\u0441\u043a\u043e\u0433\u043e \u043f\u0438\u043e\u043d\u0435\u0440\u0430\xbb \u043f\u0440\u0438 \u0432\u044d\u0431-\u0440\u0430\u0437\u0440\u0430\u0431\u043e\u0442\u043a\u0435 - backvendor (<a href="http://www.yiiframework.com/extension/backvendor/)" rel="nofollow">http://www.yiiframework.com/extension/backvendor/)</a>.'
>>>

from bleach.

Recommend Projects