Comments (7)
docs/index.rst says you'll need a less compiler, but I think you shouldn't need that unless you want to compile/minify CSS for deployment.
Btw, just adding the LESS script to the template does not seem to work, I think that's a bug in jingo-minify, it fails to set rel="stylesheet/less"
for less files so the script does not pick up those files. Sounds fixable :)
from bedrock.
I mentioned the exact same thing to jsocol, and he pointed out that it's actually type="text/less"
that need to be set (I think). Regardless, we probably should make this work. I like the fact that it compiles it server-side so that it's not always having to dynamically parse LESS, but it is annoying to have node as a requirement.
We can include the js compiler and spit out the appropriate markup if the node compiler isn't installed. I'll poke around jingo-minify to see if there's a way to get it to spit out the right rel
or type
, whichever's needed.
from bedrock.
Thanks!
lesscss.org says: <link rel="stylesheet/less" type="text/css" href="styles.less">
from bedrock.
I also agree that precompiling is neat, but I think that's something optional. We could insert the JS compiler iff the PREPROCESS setting is set to False (and TEMPLATE_DEBUG=True, of course), otherwise let node do its thing.
from bedrock.
FWIW, I upstreamed this issue to jingo-minify: jsocol/jingo-minify#20
from bedrock.
Cool. We had a few more problems doing it server-side, so I would like to see this happen. I can try to get this done next week.
from bedrock.
Moved to bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=738406
from bedrock.
Related Issues (20)
- `…see-how-firefox-for-desktop-stacks` wrong number of compared browsers HOT 3
- Github Actions need updating for the deployment pipeline
- Remove format option from newsletter preference center HOT 1
- Don't redirect to dead labs site HOT 2
- MDN icon in nav not the actual logo HOT 2
- Nested list fails to render on about/governance/policies/security-group/certs/policy HOT 3
- Internal AI Newsletter Signup Page HOT 5
- WNP 125 EU + NA
- Pushing to run-integration-tests sometimes doesn't load locale data? HOT 10
- Remove mozilla connect banner on /contribute HOT 3
- Remove CPU architecture type detection from site.js
- Remove UA client ID from stub attribution HOT 4
- Expose Desktop Nightly for Linux/ARM64 www.mozilla.org for downloads HOT 13
- Products page heading not being translated
- German homepage still has Pocket 2023 promo HOT 1
- Add CTA to Fx Features Private Page in DE and FR HOT 4
- Firefox Features pages showing download CTA in Firefox Mobile
- add UTM codes for links to monitor.mozilla.org HOT 5
- Bring back WNP118 for Fx beta 126 HOT 1
- Updates to PDF Editor Page HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bedrock.