Code Monkey home page Code Monkey logo

Comments (12)

lime124 avatar lime124 commented on August 20, 2024 1

See #343 for the spec pages.
(it's going to be better for everyone to put them in one spot to ensure they're up-to-date).

from focus-ios.

lime124 avatar lime124 commented on August 20, 2024 1

I should add - @boek and I discussed adding some telemetry so we can get some data about how often people are turning TP off and additionally turning back on. Thanks!

from focus-ios.

bbinto avatar bbinto commented on August 20, 2024

Good use case: #228

from focus-ios.

Sdaswani avatar Sdaswani commented on August 20, 2024

String is 'Trackers Blocked', approved by @BrianNJones .

from focus-ios.

antlam avatar antlam commented on August 20, 2024

I think 'Trackers Blocked' is a bit weird given the UI outlined by @lime124 in #343 ...

@BrianNJones could we take another stab at this together? :) the screenshot in the first comment is from Android (for reference) so maybe I've caused some confusion there - sorry!

from focus-ios.

lime124 avatar lime124 commented on August 20, 2024

Strings for the TP toggle setting and the description text are approved. Please refer to #343 - specs are up-to-date. Moving to ready for eng

from focus-ios.

Sdaswani avatar Sdaswani commented on August 20, 2024

@boek do you need another ticket for the telemetry or will you remember as part of this ticket?

from focus-ios.

boek avatar boek commented on August 20, 2024

@Sdaswani added a list item to the ticket description

from focus-ios.

Sdaswani avatar Sdaswani commented on August 20, 2024

Oops missed that. Lists are kewl! ;)

from focus-ios.

boek avatar boek commented on August 20, 2024

aha I added it in response to your question. You didn't miss anything

from focus-ios.

liuche avatar liuche commented on August 20, 2024

This string looks like it's already been added, so I'm not going to include it it in the Folly string export. I'm not sure why it's still flagged for strings-approved, but we should definitely improve this system!

from focus-ios.

Sdaswani avatar Sdaswani commented on August 20, 2024

Agree @liuche we have a lot of manual steps in our process, such as:

  1. someone needs to add 'needs triage' to every new ticket
  2. engineers need to remove 'strings approved' when they export the string

:(

from focus-ios.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.