Settings view about lockwise-android HOT 5 CLOSED

@nickbrandt @changecourse what should the behavior of the app version be on very small screens? @eliserichards and I are worried about the settings view being able to scroll under it in some cases. Could it be part of the settings list or ??

from lockwise-android.

Ah, makes sense... ok, we're updating the positioning of the App Version to be anchored to the base of the settings list view, rather than the base of the device. Does that work?

from lockwise-android.

@changecourse sounds good!! that looks much easier implementation-wise.

thanks!

from lockwise-android.

Adding my pseudo-UML diagrams of the two proposed implementations (hard-coded sectioned view and PreferenceFragmentCompat). (These were just made for my own reference)

from lockwise-android.

Thanks for adding those! They’re a great practice, help improve clarity and understanding, and can be really helpful to come back to in a few weeks/months if we need to retrace our steps and thinking.

from lockwise-android.