Add anchors for all graphs about firefox-performance-dashboards HOT 5 CLOSED

Hi @echessa I'm looking forward to work together when things get better for you and I hope to see you around for the next Outreachy term. I completely understand that life gets busy.

I've closed it. Take care!

from firefox-performance-dashboards.

Hi @armenzg I found this project on Outreachy. I have added anchors to the graphs. Let me know if the fix is/isn't okay.

from firefox-performance-dashboards.

Hi @echessa I have not heard back from you. I will let other people work on this unless you tell me you can jump back to it very soon. Thanks for all your help so far.

from firefox-performance-dashboards.

Hi @armenzg. Sorry about the very long delay in completing the task. I got a bit busy, so I haven't had time to work on it. I decided not to apply for this intake of Outreachy because I will be quite busy during that time. I might do it for the next intake. I thought I would still close this issue, but since @aimenbatool is already working on it, then let me just leave it to her instead of cause further delays.

Should I close my PR or will you?

from firefox-performance-dashboards.

After some of my findings I believe it is best to close this as it was not a users' request.

I ... remember there [is] a major issue (I didn't think of this when filing the issue).
If I gave you (or anyone) a link like this:
https://deploy-preview-109--firefox-performance-dashboard.netlify.com/win10/overview?numDays=90#wasm-godot-overview
You will not end up at the "WebAssembly Godot" section.

That is because of the data is fetched outside of this container

It is actually not due that the data is being fetched outside the container. See next comment.

This is not easy to achieve.
I tried to add the anchors before we go and try to asynchronously fetch the data:
https://github.com/mozilla-frontend-infra/firefox-performance-dashboard/compare/aimenbatool-Add-anchors-to-graph#diff-f4781f120269b5a972780d6fd4f5a884R57

It is possible that this is a solution:
https://stackoverflow.com/a/45777157/513672
From the React router hash link docs:

This will also work for elements that are created after an asynchronous data load.

I'm leaning towards closing this and forgetting about it since no one asked for this feature.

from firefox-performance-dashboards.