The drilldowns don't work properly about firefox-performance-dashboards HOT 3 CLOSED

If you visit the Linux64 page (the issue does not have on the win10 page):
https://arewefastyet.com/linux64/overview?numDays=90

This issue is on every platform even on win10.

the same will happen, however, if you enter the following:
https://arewefastyet.com/linux64/ares6?numDays=90

It works for any numDays value.

I updated code and removed timeRange from validation here and here.

Then upon clicking drill down link page didn't display anything except the two pickers and time range slider. It doesn't load anything untill I choose any time from time range.
I short, removing timeRange didn't work as expected there is something else involved.

I believe this was working fine when I added drilldown link. How come we didn't test and this code is merged. I think this time range was added after adding drilldown link and that is causing issue.

One solution is that we pass numDays as paramter to drilldown url. So, whenever it gets clicked it passes some numDays value to url which can be the default selected value.

from firefox-performance-dashboards.

Yes, passing a default value will be good.

In general, unless we add tests to test the code it is very easy to cause regressions when new code is landed.

from firefox-performance-dashboards.

Thanks for the fix!

from firefox-performance-dashboards.