Code Monkey home page Code Monkey logo

Comments (10)

mourner avatar mourner commented on August 16, 2024

Please be more specific. What did you expect, and what do you get instead? Can you set up a test case with exact coordinates and tolerance values used?

from simplify-js.

gcmartijn avatar gcmartijn commented on August 16, 2024

Here you go: http://s3.postimg.org/67v1cbezn/example.png

As you can see, I thought it would respect the corner points, and give me only the corners with a very high tolerance.

Coordinates, outline:
93,1
93,2
93,3
93,4
93,5
93,6
93,7
93,8
93,9
93,10
93,11
93,12
93,13
93,14
93,15
93,16
93,17
93,18
93,19
93,20
93,21
93,22
93,23
93,24
93,25
93,26
93,27
93,28
93,29
93,30
93,31
93,32
93,33
93,34
93,35
93,36
93,37
93,38
93,39
93,40
93,41
93,42
93,43
93,44
93,45
93,46
93,47
93,48
93,49
93,50
93,51
93,52
93,53
93,54
93,55
93,56
93,57
93,58
93,59
93,60
93,61
93,62
93,63
93,64
93,65
93,66
93,67
93,68
93,69
93,70
93,71
93,72
93,73
93,74
93,75
93,76
93,77
93,78
93,79
93,80
93,81
93,82
93,83
92,83
91,83
90,83
89,83
88,83
87,83
86,83
85,83
84,83
83,83
82,83
81,83
80,83
79,83
78,83
77,83
76,83
75,83
74,83
73,83
72,83
71,83
70,83
69,83
68,83
67,83
66,83
65,83
64,83
63,83
62,83
61,83
60,83
59,83
58,83
57,83
56,83
55,83
54,83
53,83
52,83
51,83
50,83
49,83
48,83
47,83
46,83
45,83
44,83
43,83
42,83
41,83
40,83
39,83
38,83
37,83
36,83
35,83
34,83
33,83
33,84
33,85
33,86
33,87
33,88
33,89
33,90
33,91
33,92
33,93
33,94
33,95
33,96
33,97
33,98
33,99
33,100
33,101
33,102
33,103
33,104
32,104
31,104
31,105
31,106
31,107
31,108
31,109
31,110
31,111
31,112
31,113
31,114
31,115
31,116
31,117
31,118
31,119
31,120
31,121
31,122
31,123
31,124
31,125
31,126
31,127
31,128
31,129
31,130
31,131
31,132
31,133
31,134
31,135
31,136
31,137
31,138
31,139
31,140
31,141
31,142
31,143
31,144
31,145
31,146
31,147
31,148
31,149
31,150
31,151
31,152
31,153
31,154
31,155
31,156
31,157
31,158
31,159
31,160
31,161
31,162
31,163
31,164
31,165
31,166
31,167
31,168
31,169
31,170
31,171
31,172
31,173
31,174
31,175
31,176
31,177
31,178
31,179
31,180
31,181
31,182
31,183
31,184
31,185
31,186
31,187
31,188
31,189
31,190
31,191
31,192
31,193
31,194
31,195
31,196
31,197
31,198
31,199
31,200
32,200
33,200
34,200
35,200
36,200
37,200
38,200
39,200
40,200
41,200
42,200
43,200
44,200
45,200
46,200
47,200
48,200
49,200
50,200
51,200
52,200
53,200
54,200
55,200
56,200
57,200
58,200
59,200
60,200
61,200
62,200
63,200
64,200
64,199
64,198
64,197
64,196
64,195
64,194
64,193
64,192
64,191
64,190
64,189
64,188
64,187
64,186
64,185
64,184
64,183
64,182
64,181
64,180
64,179
64,178
64,177
64,176
64,175
64,174
64,173
64,172
64,171
64,170
64,169
64,168
64,167
64,166
64,165
64,164
64,163
64,162
64,161
64,160
64,159
64,158
64,157
64,156
64,155
64,154
64,153
64,152
64,151
64,150
64,149
64,148
64,147
64,146
64,145
64,144
64,143
64,142
64,141
64,140
64,139
64,138
64,137
64,136
64,135
64,134
64,133
64,132
64,131
64,130
64,129
64,128
64,127
64,126
64,125
64,124
64,123
64,122
64,121
64,120
64,119
64,118
64,117
64,116
64,115
64,114
64,113
64,112
64,111
64,110
64,109
64,108
64,107
65,107
66,107
67,107
68,107
69,107
70,107
71,107
72,107
73,107
74,107
75,107
76,107
77,107
78,107
79,107
80,107
81,107
82,107
83,107
84,107
85,107
86,107
87,107
88,107
89,107
90,107
91,107
92,107
93,107
94,107
95,107
96,107
97,107
98,107
99,107
100,107
101,107
102,107
103,107
104,107
105,107
106,107
107,107
108,107
109,107
110,107
111,107
112,107
113,107
114,107
115,107
116,107
117,107
118,107
119,107
120,107
121,107
122,107
123,107
124,107
125,107
126,107
127,107
128,107
128,108
128,109
128,110
128,111
128,112
128,113
128,114
128,115
128,116
128,117
128,118
128,119
128,120
128,121
128,122
128,123
128,124
128,125
128,126
128,127
128,128
128,129
128,130
128,131
128,132
128,133
128,134
128,135
128,136
128,137
128,138
128,139
128,140
128,141
128,142
128,143
128,144
128,145
128,146
128,147
128,148
128,149
128,150
128,151
128,152
128,153
128,154
128,155
128,156
128,157
128,158
128,159
128,160
128,161
128,162
128,163
128,164
128,165
128,166
128,167
128,168
128,169
128,170
128,171
128,172
128,173
128,174
128,175
128,176
128,177
128,178
128,179
128,180
128,181
128,182
128,183
128,184
128,185
128,186
128,187
128,188
128,189
128,190
128,191
128,192
128,193
128,194
128,195
128,196
128,197
128,198
128,199
128,200
129,200
130,200
131,200
132,200
133,200
134,200
135,200
136,200
137,200
138,200
139,200
140,200
141,200
142,200
143,200
144,200
145,200
146,200
147,200
148,200
148,199
148,198
148,197
148,196
148,195
148,194
148,193
148,192
148,191
148,190
148,189
148,188
148,187
148,186
148,185
148,184
148,183
148,182
148,181
148,180
148,179
148,178
148,177
148,176
148,175
148,174
148,173
148,172
148,171
148,170
148,169
148,168
148,167
148,166
148,165
148,164
148,163
148,162
148,161
148,160
148,159
148,158
148,157
148,156
148,155
148,154
148,153
148,152
148,151
148,150
148,149
148,148
148,147
148,146
148,145
148,144
148,143
148,142
148,141
148,140
148,139
148,138
148,137
148,136
148,135
148,134
148,133
148,132
148,131
148,130
148,129
148,128
148,127
148,126
148,125
148,124
148,123
148,122
148,121
148,120
148,119
148,118
148,117
148,116
148,115
148,114
148,113
148,112
148,111
148,110
148,109
148,108
148,107
149,107
150,107
151,107
152,107
153,107
154,107
155,107
156,107
157,107
158,107
159,107
160,107
161,107
162,107
163,107
164,107
165,107
166,107
167,107
168,107
169,107
170,107
171,107
172,107
172,106
172,105
172,104
172,103
172,102
172,101
172,100
172,99
172,98
172,97
172,96
172,95
172,94
172,93
172,92
172,91
172,90
172,89
172,88
172,87
172,86
172,85
172,84
172,83
171,83
170,83
169,83
168,83
167,83
166,83
165,83
164,83
163,83
162,83
161,83
160,83
159,83
158,83
157,83
156,83
155,83
154,83
153,83
152,83
151,83
150,83
149,83
148,83
147,83
146,83
145,83
144,83
143,83
142,83
141,83
140,83
139,83
138,83
137,83
136,83
135,83
134,83
133,83
132,83
131,83
130,83
129,83
128,83
127,83
126,83
125,83
124,83
123,83
122,83
121,83
120,83
119,83
118,83
117,83
116,83
115,83
115,82
115,81
115,80
115,79
115,78
115,77
115,76
115,75
115,74
115,73
115,72
115,71
115,70
115,69
115,68
115,67
115,66
115,65
115,64
115,63
115,62
115,61
115,60
115,59
115,58
115,57
115,56
115,55
115,54
115,53
115,52
115,51
115,50
115,49
115,48
115,47
115,46
115,45
115,44
115,43
115,42
115,41
115,40
115,39
115,38
115,37
115,36
115,35
115,34
115,33
115,32
115,31
115,30
115,29
115,28
115,27
115,26
115,25
115,24
115,23
115,22
115,21
115,20
115,19
115,18
115,17
115,16
115,15
115,14
115,13
115,12
115,11
115,10
115,9
115,8
115,7
115,6
115,5
115,4
115,3
115,2
115,1
115,0
114,0
113,0
112,0
111,0
110,0
109,0
108,0
107,0
106,0
105,0
104,0
103,0
102,0
101,0
100,0
99,0
98,0
97,0
96,0
95,0
94,0
93,0

from simplify-js.

mourner avatar mourner commented on August 16, 2024

That's pretty weird, shouldn't work this way. I'll check this out.

from simplify-js.

gcmartijn avatar gcmartijn commented on August 16, 2024

mmm maybe its my code then, check this later
Op 26 mei 2015 16:06 schreef "Vladimir Agafonkin" <[email protected]

:

That's pretty weird, shouldn't work this way. I'll check this out.


Reply to this email directly or view it on GitHub
#15 (comment).

from simplify-js.

mourner avatar mourner commented on August 16, 2024

@gcmartijn yeah, looking at the picture, it looks like it shows everything except the points that simplify.js retained.

from simplify-js.

gcmartijn avatar gcmartijn commented on August 16, 2024

I'm now using your code directly to check where the problem is.
https://jsfiddle.net/5e2bot1r/1/

If you run it, you can see the wrong dots.

from simplify-js.

mourner avatar mourner commented on August 16, 2024

@gcmartijn hmm, your fiddle doesn't show anything for me in Chrome, just a blank screen.

from simplify-js.

mourner avatar mourner commented on August 16, 2024

@gcmartijn nevermind, seeing the points. If you run it with proper tolerance (say 1), the result is good — just the important corners.

from simplify-js.

gcmartijn avatar gcmartijn commented on August 16, 2024

I'm using the latest chrome, don't you see the red pixel (right side) when when push Run?
http://s16.postimg.org/5f3vqacnp/Screen_Shot_2015_05_31_at_13_05_07.png

from simplify-js.

gcmartijn avatar gcmartijn commented on August 16, 2024

I see now, maybe its the python module, going to recheck that again.

from simplify-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.