Code Monkey home page Code Monkey logo

Comments (12)

Mottie avatar Mottie commented on May 20, 2024

Hi Severa!

Hmm, that sounds like a good idea! I'll add it to my to do list :)

from tablesorter.

Mottie avatar Mottie commented on May 20, 2024

Ok!

I've added a new option named sortRestart (since sortReset was already used) which seems to work as you expect; but it might do a little something odd when you click on a column after multi-column sorting. Here is how to duplicate the wierdness (if it really is that bad):

  • Sort the first column (now in sortInitialOrder)
  • Next, shift sort the second twice (so it's in !sortInitialOrder
  • Lastly, click (no shift) on the second column. It will sort in the !sortInitialOrder direction...

It doesn't seem that bad, but I wanted to see what you thought,

from tablesorter.

severa avatar severa commented on May 20, 2024

Hi Mottie. Interesting, I am using 'desc' sortInitialOrder and this change seems to cause that setting to be ignored. So while it now does restart from sortInitialOrder each time you switch back to a column, it only works for 'asc' sort order (in fact, that setting seems hard-coded now). Was that intentional? I also noticed that the value does not seem to be able to be applied via a header (ie to override for a specific column). Was that also intentional?
I agree that the shift sort option introduces a tricky situation (actually that is the same behavior as before the change so maybe the caveat can be that sortInitialOrder does not apply to multi-column scenarios? :-) ).

from tablesorter.

Mottie avatar Mottie commented on May 20, 2024

Hmm, it's a bit more complicated than I thought... give me some time to work on a fix :P

from tablesorter.

severa avatar severa commented on May 20, 2024

:-) Yes, I thought it might be. Sorry about that. But I do think its a useful feature. One scenario where I think its particularly helpful is when you have table that consist of similar statistics over multiple time periods (eg test score results for different years). A common use-case in that situation is to want to know who was the top performer in a single year, then the top performer in another year. Or the lowest performer, or top 5 performers, etc. With that kind of homogenous data, it is beneficial to be able to easily make such comparisons by column with only a single click. Thanks!

from tablesorter.

Mottie avatar Mottie commented on May 20, 2024

Just letting you know that I'm still trying to fix this bug. If I can't get it by this weekend, I'll save it for the next update.

from tablesorter.

Mottie avatar Mottie commented on May 20, 2024

Grrr, I didn't get this fix included in version 2.1... but I'll keep working on it. Sorry!

from tablesorter.

severa avatar severa commented on May 20, 2024

Ok, sorry for the frustration. :-)

from tablesorter.

Mottie avatar Mottie commented on May 20, 2024

Okie dokie, I think I finally got it fixed! YAY!!

Check out the new demo in version 2.1.1.

from tablesorter.

Mottie avatar Mottie commented on May 20, 2024

Well, I guess it's working? I'm going to go ahead and close this issue. If you find any problems with the updates, please feel free to reopen this issue. Thanks!

from tablesorter.

severa avatar severa commented on May 20, 2024

Sorry, I haven't had a chance to test it thoroughly. I will try over the weekend. Thanks!

#end

On Mar 16, 2012, at 9:22 PM, Rob [email protected] wrote:

Well, I guess it's working? I'm going to go ahead and close this issue. If you find any problems with the updates, please feel free to reopen this issue. Thanks!


Reply to this email directly or view it on GitHub:
#30 (comment)

from tablesorter.

severa avatar severa commented on May 20, 2024

Hi Mottie. Thanks a lot for this, this is perfect! Sorry for the delay.

from tablesorter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.