Comments (7)
Hi @jerone!
That sounds like a good idea, I'll take a look!
from github-userscripts.
Derp, all I needed to do was to add css to hide the first whitespace element added by the userscript.
from github-userscripts.
@Mottie Saw you commit, all inline whitespaces work perfectly now. 🎉
I do however see an extra space character before every line now. For example jerone/UserScripts@0c1e262, the first userscript block in GitHub_Commit_Compare.user.js is not prefixed with a space in the code, still I see the space character.
Hope you can reproduce and find a solution.
from github-userscripts.
Hmm, the space you're reporting, I think, is due to the replacement of the "+" (or "-") in the diff. So the script that is replacing that symbol is the culprit; it's the github-remove-diff-signs.user.js
script, if you're using it.
I do however see an issue in the readme file from that same commit - it looks like the space inside the span is being removed and the carriage returns are misaligned. I'll try to work on this later today.
from github-userscripts.
@Mottie commented on Oct 2, 2017, 2:56 PM GMT+2:
Hmm, the space you're reporting, I think, is due to the replacement of the "+" (or "-") in the diff. So the script that is replacing that symbol is the culprit; it's the
github-remove-diff-signs.user.js
script, if you're using it.
You are right, I'm using that script. Maybe you can use a different whitespace character for that...
I do however see an issue in the readme file from that same commit - it looks like the space inside the span is being removed and the carriage returns are misaligned. I'll try to work on this later today.
Just noticed it too. It's not showing any whitespace character.
from github-userscripts.
Maybe you can use a different whitespace character for that...
I tried that, but I think it's best to completely remove the "+", "-" or first space because the whole reason we're doing it is to make it easier to copy/paste the code. The main issue then becomes removing the leading space in the expanded code section. I'll leave the detection and processing of the expanded section for a later version.
It's not showing any whitespace character.
It's the weirdest thing ever... I had to switch all the spans to use display: inline
to get them to show, then I found that only the diffs for markdown and non-extension files (e.g. LICENSE) were effected by a misalignment of the placeholder symbols.
I ended up adding a work-around to adjust the specific diff files and then removing all tab-size adjustment code since I couldn't set a width with display: inline
. It should all be working smoothly now.
from github-userscripts.
It should all be working smoothly now.
It works great now! Thanks for fixing so fast.
from github-userscripts.
Related Issues (20)
- It can't sort if the cell contains an emoji HOT 1
- GitHub Issue Add Details - no longer works HOT 3
- GitHub in VSCode: Disable button `@media print` HOT 1
- feature request? bug?: GitHub issue comments: support hiding linked commits HOT 5
- FireMonkey Compatibility
- Custom navigation formatting on github projects page HOT 6
- Github Title Notification is broken HOT 8
- Feature request: show source code structure (list of classes, methods, functions, etc.)
- "GitHub Diff Filename" only work when reloading on the diff page HOT 4
- Greasy Fork followup
- github-static-time: Option to show UTC HOT 5
- Mutations not firing when clicking "Pull Requests" tab
- GitHub Watcher issue: Some repositories are not uploading HOT 3
- scripts doesn't work when enter the page first time HOT 2
- Request: add script of README.md editor
- GitHub Sort Content no longer works when logged in HOT 3
- GitHub code folding - the last block does not get a folding arrow
- GitHub static time - prevent text wrapping?
- Open Extension Page is just broken now. HOT 6
- [Request]Filter Forks by Releases
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from github-userscripts.