Collapse-in-comment always starts collapsed about github-userscripts HOT 11 OPEN

Hi @aspiers!

Make sure to reload the page (Shift + F5) after changing the option as the script is loaded into the page and does not refresh because GitHub uses ajax page loading.

I just update the documentation to emphasize this necessity.

from github-userscripts.

false appears to be the default value (at least it was for me), so this is a problem even without changing the option. I also tried changing to true and reloading and the behaviour didn't change.

from github-userscripts.

The setting will always initially show the opposite of the current setting - see line 233.

LOL, actually, I just tested it and it does toggle the areas even without a page reload.

Maybe there is another script interfering? Are you using Octopatcher?

from github-userscripts.

Oh, I see! So when I typed in true, I wasn't actually changing it at all :-)

Hmm, this is not an intuitive UI at all. Perhaps you can think of some way to make it clearer, e.g. tweaking the text?

from github-userscripts.

To be clear, it does work now I understand how it's supposed to work :-)

from github-userscripts.

What would you suggest?

from github-userscripts.

In Octopatcher (an addon created from this userscript), I set a select with two options: collapsed & expanded. Does that make more sense?

Also, I'm going out of town on the 4th, I'll be unavailable for a month, or so. So please don't think I'm ignoring you if I don't respond.

from github-userscripts.

That sounds better but I'd have to see it to be sure.

from github-userscripts.

Updated.

from github-userscripts.

Thanks - this is better for sure, but the main source of the confusion is still there, i.e. that the value auto-populated in the dialog is the opposite of the current state, so that you only have to click OK to change it. Could the text also give the current state, or clarify this somehow?

from github-userscripts.

Ok, the current state is now visible.

Eventually, I'd like to change out the prompt for a modal window with a select and number input similar to what I have set up for Octopatcher, but without the "Enabled" checkbox:

from github-userscripts.