Code Monkey home page Code Monkey logo

Comments (3)

grunch avatar grunch commented on June 11, 2024 1

I like it, let's do it like that 🔥

from mostro.

arkanoider avatar arkanoider commented on June 11, 2024

Hi @grunch , I was thinking about a thing during the test of sell order published. Let me know what you think.

I am thinking to use just Takesell command to get also marketplace order, because in the end the logic is very similar to the new SendInvoice command. Let me breakdown my simple idea:

  1. Seller publish sell order at market price.
  2. Buyer sees the offer and Takesell it.
  3. Mostro checks that offer is market price kind and sends a dm to buyer with Invoice details on amount : price calculated + premium
  4. Buyer gets the message, creates the invoice on his wallet and sends again a Takesell to mostro with the correct invoice
  5. Mostro shows hold invoice to seller and then we proceed as usual.

I just think this is good because the SendInvoice will do quite the the same logic of takesell with the exception of showing hold invoice to seller, so we avoid another command and some repetitive code on the CLI.

Let me know!

from mostro.

grunch avatar grunch commented on June 11, 2024

closing via PR #9 and #20

from mostro.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.