Comments (2)
Yes, I makes more sense to put the URL in the Searcher class. I am planning to use a class variable inside this class to have the URL like below
class GoogleSearcher implements Searcher { protected WebDriver $driver; protected string URL = ''https://www.google.com/search?hl=en&q='' }
It's a bit like hardcoding the URL. Which is sometimes discouraged.
Another way would be to read the value from .env and push it through the constructor.
I am assuming google won't change the search URL anytime soon. So, I am thinking about implementing the first solution. What's your thoughts on that?
from bemoban-backend.
Yes, I makes more sense to put the URL in the Searcher class. I am planning to use a class variable inside this class to have the URL like below
class GoogleSearcher implements Searcher
{
protected WebDriver $driver;
protected string URL = ''https://www.google.com/search?hl=en&q='';
}
It's a bit like hardcoding the URL. Which is sometimes discouraged.
Another way would be to read the value from .env and push it through the constructor by a config class.
I am assuming google won't change the search URL anytime soon. So, I am thinking about implementing the first solution. What's your thoughts on that?
from bemoban-backend.
Related Issues (1)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bemoban-backend.