Code Monkey home page Code Monkey logo

Comments (4)

summeraz avatar summeraz commented on June 24, 2024

I'm guessing this is the atom that Foyer is finding multiple types for. Determining which atom types get precedence (and thus which overrides you need) when an atom is part of multiple functional groups gets a bit tricky. In this case, however, my opinion would be that 'opls_713' should override 'opls_139'. This is something you would need to change in oplsaa.xml (and could submit a PR while you're at it!). The OPLS force field in Foyer is obviously fairly incomplete, so we're hoping that as users begin to use various atom types it will begin to fill out.

from foyer.

mikemhenry avatar mikemhenry commented on June 24, 2024

I wasn't sure if there was a way to do this without editing the oplsaa.xml file by hand/if there was a way to do this programmatically, something like oplsaa.override(['opls_713'],['opls_139'])

from foyer.

summeraz avatar summeraz commented on June 24, 2024

I don't think you can manually add overrides to a Forcefield object as this is intended to all be handled within the XML file.

from foyer.

ctk3b avatar ctk3b commented on June 24, 2024

Yeah as @summeraz said, the intention is to have this contained in the xml file. We could think about implementing an interactive prompt for resolving overrides when you're creating a new forcefield but at the end of the day all the logic is intended to be captured in the file itself.

from foyer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.