onMouseUp() does not do what it should do ? about react-avatar-editor HOT 6 CLOSED

An 'onImageChange' callback would be very nice to have and it could also signal other image-changes like a scale-change.

from react-avatar-editor.

We also need to track the mouseup event outside the editor because you might be outside of the area while dragging the image.
We could think about an 'onImageChange' callback that the editor calls whenever there are changes. I'm curious what you need this for?

from react-avatar-editor.

I need this to be notified whenever the image changes (there is no 'Save' button where I use this)
I can hack it to work for me if I change this:

       handleMouseUp: function handleMouseUp() {
            if (this.state.drag) {
                this.setState({ drag: false });
            }
            this.props.onMouseUp();
        }

to this:

       handleMouseUp: function handleMouseUp() {
            if (this.state.drag) {
                this.setState({ drag: false });
                this.props.onMouseUp();
            }
        }

Thanks for looking into this!

from react-avatar-editor.

I'd like an onImageChange as well – for example, I would use it to enable/disable the upload button.

from react-avatar-editor.

This should be no problem at all to implement, just add a callback in the end of the paint() method.

from react-avatar-editor.

close. #113 merged

from react-avatar-editor.