Difficult to use in ES6 module package. about aedes HOT 10 CLOSED

Please consider opening a PR to fix this issue

from aedes.

As I mentioned here, and may be useful for others...this PR breaks TypeScript in straightforward use cases with simple tsconfigs.

I would suggest this PR is reverted or updated to correct the errors. Removing the code introduced in the PR fixes the issue.

from aedes.

@hjdhjd Would you like to submit a PR to fix that?

from aedes.

Happy to, but it would be to revert the changes made in the prior PR. If you're good with that, I will be happy to submit it.

from aedes.

isn't there a way to keep the changes and fix what's not working?

from aedes.

The changes are the problem - they shouldn't be there in the first place because the prior code was correct. Here's a helpful stackoverflow answer: https://stackoverflow.com/questions/55506545/export-assignment-and-exporting-types-in-typescript-ambient-module

In experimenting with aedes for a couple of days it seems many of the TypeScript typings are either incorrect or ambiguously defined. I'll take a closer look all around and put together a PR to correct some of them.

from aedes.

@hjdhjd I agree types can be imrpved a lot, go for the PR I will take a look 👍🏼

from aedes.

@hjdhjd I agree types can be imrpved a lot, go for the PR I will take a look 👍🏼

Submitted.

from aedes.

I just encountered a similar issue when trying to import in Typescript a module exported with module.exports = TheModule.
Since TheModule (in that case, ClinicBubbleprof from @clinic/bubbleprof) has no type definitions, I created them and the correct way to export it was by using export = TheModule.
Then in the TS file, the import was done with import TheModule = require('path-to-the-module');
To keep on using the import X from x syntax, i had to set esModuleInterop=true in compilerOptions.

Reference

from aedes.

@getlarge This should have been fixed by #918

from aedes.