Comments (5)
As a suggested alternative to this, perhaps we can have an option to load an arbitrary yml file into the mix.
Right now, the moodle-docker-compose script combines multiple yml files using something like:
dockercompose="${dockercompose} -f "${basedir}/another/file.yml"
Perhaps we can have this include a local.yml
if one is available in the basedir, and that can contain any personal additions, like adminer, etc. if that is the individuals' preference.
I do think that adminer/etc. are useful, but if we start to bundle every tool under the sun, then where do we stop, and at what point does it become too difficult to use because of the plethora of options that you may need, and which need to specified prior to calling composer up.
from moodle-docker.
Submitted a pull request #236 which adds the requested feature.
from moodle-docker.
Hi @michael-milette ,
thanks for your contribution! I must confess that I'm not 100% sold about the idea of start adding tools to the docker composition as #236 does. There are various points about that:
- The number of DB managers can be endless. What if somebody wants to add pgadmin, or xxxmin, ot zzzmin? What decides which ones are worth the effort of being maintained?
- What if people start asking for other tools, say CodeSniffer, or Psalm, or PHPmd, or ... (just imagining...) at which point we should stop.
- In the case of adminer/phpmyadmin ... there are already moodle plugins embedding them within Moodle, isn't it? So a developer could have them just in place in their dev environment and done.
- Also, for the case of DB managers, we recently added the ability of making the databases accessible from the host, so they can be kept 100% apart, in the host or any other system perfectly.
So, as said... I'm not convinced about this, as a concept. I'm going to gather opinions in the team about this issue (and the PR). Again, thanks for proposing it!
Ciao :-)
from moodle-docker.
I love adminer (since I met it, I haven't used any other database client) but I can see why Eloy is raising this concern. Instead of having adminer or any other tool in the moodle-docker, I would prefer having documented how to use them locally.
from moodle-docker.
Re: @stronk7's reference in point 4. - this was done in #222 and is great for allowing local connections to the Docker DB
Not convinced we should be bundling these tools either
from moodle-docker.
Related Issues (20)
- Missing license information HOT 1
- MacOS Selenium ARM Images HOT 2
- Add MOODLE_DOCKER_DBHOST HOT 3
- breakpoints for phpUnit Tests when running in the container HOT 5
- Document Docker CLI version requirements HOT 4
- Invalid interpolation format HOT 2
- Webserver exits on M1 HOT 11
- Add support for new sqlsrv driver that is using odbc18 HOT 1
- help: fresh install keeps logining out as time out HOT 10
- Switch from mailhog to mailpit
- interest on having wrapping scripts? HOT 2
- Issue with Windows WSL2 and latest version of moodle docker HOT 4
- Add support for local certificates for Windows
- Forbidden HOT 5
- Mailpit UI no longer accessible HOT 1
- Cover mailpit with some integration tests
- HEADs UP: This repo has moved from "master" to "main"
- Env var to flag moodle-docker environment running HOT 5
- Document AMD build step HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from moodle-docker.