Storing stuff in $SESSION not ideal about moodle-local_bulkenrol HOT 3 CLOSED

I don't personally see this as a big issue.

• The plugin is correctly using the SESSION wrapper and not the PHP's native $_SESSION superglobal.
• It stores data there in its own namespace.

As far as I understand it, the preferred way these days would be a properly defined MUC session cache maybe but the current code does not look necessarily wrong to me.

from moodle-local_bulkenrol.

Yeah - not a big issue for a 3rd party plugin. Feel free to close as won't fix! :-)

from moodle-local_bulkenrol.

Hi Dan,

I finally found the time to polish this plugin for plugin repo approval.
Thanks for this hint.

While I would generally agree and think that this should better be a MUC session cache, this is the way the original developer built the plugin and I am happy that this is no show-stopper for approval.

Closing as won't fix ;)

Cheers,
Alex

from moodle-local_bulkenrol.