Exercise Set 8, question 3 ( implement a rectangle) - the given coordinate is the bottom-left one, not upper-left about haskell-mooc HOT 5 CLOSED

I tried to add a clarification about the coordinate system earlier in commit b88f788 – perhaps you're working on an older version of the exercises? Apologies for the confusion and I'd be glad to make this even clearer if you have a suggestion!

from haskell-mooc.

I think the test has adapted, see 5bb4294.

from haskell-mooc.

@muzimuzhi Thank you for linking that commit - it helps understand the situation better.

Another interesting bit is that the test file has this line of code for the given exercise (which I had wrongly marked as exercise 4 instead of exercise 3, fixed now!) - conjoin [checkShape x y True rect | x <- [x0..x0+w-1], y <- [y0..y0+h-1]]

So it it does take values in the range [x0, x0+w) and [y0, y0+h). So my assumption was right, and as per your commit link, they did have the intention of modifying the expectation to be that of a rectangle whose upper-left coordinates are given, but in the "screen coordinate system".

I think the text of the question should be updated to make it consistent - either mention that this is the "screen coordinate/graphics coordinate system" with the given coordinates as the upper-left corner of the rectangle, or that the given coordinates are for the bottom-left corner (assuming the normal Euclidean coordinate system).

from haskell-mooc.

I tried to add a clarification about the coordinate system earlier in commit b88f788 – perhaps you're working on an older version of the exercises? Apologies for the confusion and I'd be glad to make this even clearer if you have a suggestion!

Thank you for clearing that up! I must admit that it's my mistake as I had not read that part at all. I should have read the comments in the exercises in order.

Since the comment explains the coordinate system in use, I don't think there is really anything that should be changed (especially seeing as to how no else has mentioned it), so I'll close the issue now.

Thanks for the help, @muzimuzhi and @opqdonut, and sorry for the unnecessary confusion! :-)

from haskell-mooc.

Closing since it is a non-issue. The comments in the file mentions how the coordinate system is supposed to work, and I failed to read it.

from haskell-mooc.