circular dependencies (causing errors in demo script) about collections HOT 3 CLOSED

Thanks, @bcw, I’ll take a look. And I’ll make a point to get better coverage on iterator. It is presently the lowest at 67% and I can do better. Glad that at least the idea of the iterator type is working out for you.

from collections.

Fixed in 3e1f9c9

from collections.

For reference, Node’s module system is designed to handle cyclic dependencies (I championed the CommonJS modules specification), but some care has to be taken to linearize the execution, usually by imagining the conjoined modules as a single file and placing require calls for every module in the clique in the position where the other module was elided.

Thankfully, @dherman’s proposal for modules in ES6 averts most of this problem by hoisting imports and exports into a shared scope (but allowing the same variable to have different names in each module, a feature I call “module sovereignty”—people in the know probably call it something else).

Which brings up another issue, @dherman. In this particular group of cyclic dependencies, the latter module uses a feature provided by the previous module in the course of its initialization. I believe @dangoor convinced you some years ago to execute a dependency module on the stack of the first import. This is an exemplar of the convincing use-case.

module "kriskowal/collections/generic-collection" {
    GenericCollection.prototype.addEach = …
    import "./array-shim";
}

module "kriskowal/collections/shim-array" {
    let GenericCollection = import "./generic-collection";
    Array.prototype.addEach = GenericCollection.prototype.addEach;
}

(details fudged)

from collections.