Comments (5)
monperrus
commented on June 27, 2024
Thanks for reporting the issue. What would be a re2 compatible pattern? Could you see how to integrate a re2 check in validate.py?
from crawler-user-agents.
vetyy
commented on June 27, 2024
Hey,
I have created pull request for re2 validation check.
If you want the original regex to match the same thing as it is right now and it should be compatible with re2, I believe this is fine: "AdsBot-Google(?!-)" == "AdsBot-Google([^-]|$)"
But then we should not forget to add "AdsBot-Google-Mobile" user agent to the list.
I can create pull request for that too, just tell me what do you prefer? To have multiple regexes or just one that is general.
from crawler-user-agents.
monperrus
commented on June 27, 2024
I believe this is fine: "AdsBot-Google(?!-)" == "AdsBot-Google([^-]|$)"
OK
But then we should not forget to add "AdsBot-Google-Mobile" user agent to the list.
OK Let's dot that in three different PRs one by one
from crawler-user-agents.
vetyy
commented on June 27, 2024
PRs are ready for you.
from crawler-user-agents.
monperrus
commented on June 27, 2024
Thanks a lot, it seems we're done. This was also an opportunity to improve the validation script.
from crawler-user-agents.
Related Issues (20)
- Headless browser User agents HOT 6
- Raw list of user-agents HOT 1
- add a script to generate robots.txt
- Add centurybot9 HOT 1
- Automatic npm continuous deployments broken HOT 1
- Add Pingdom bots HOT 1
- Feature request virustotal HOT 2
- Addition suggestion HOT 4
- Add Freshping bot HOT 1
- Adding new version of existing bot entry HOT 1
- Consider add Google-Read-Aloud to the bot list HOT 1
- Add Dynatrace / RuxitSynthetic into the list
- Add linespider HOT 3
- Please also register this on packagist.org to use it via Composer HOT 5
- Add GPTBot HOT 1
- I noticed a recent bot which I believe is coming from Tencent but can't find documentation for - Ottabot HOT 1
- Add WordPress Bot/Crawler HOT 2
- Add AI agents HOT 1
- port CI to GithubActions HOT 4
- Suggestion: test against false positives HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from crawler-user-agents.